Problem/Motivation

  • Fix InvalidArgumentException to input a value at aws_cloud_instance_notification_hour and aws_cloud_instance_notification_minute

Issue fork cloud-3240707

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yutong.li created an issue. See original summary.

yutong.li credited yas.

yutong.li’s picture

yutong.li commented

yutong.li opened merge request !439

yutong.li’s picture

yutong.li commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@yutong.li

Thank you for the fix. It looks good. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed d165696 on 4.x authored by yutong.li 
    Issue #3240707 by yutong.li, yas: Fix InvalidArgumentException to input...

yas closed merge request !439

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yutong.li’s picture

yutong.li commented
Status: Fixed » Needs work

yutong.li reopened merge request !439

yutong.li’s picture

yutong.li commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@yutong.li

Thank you for the fixes. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed f88f2e0 on 4.x authored by yutong.li 
    Issue #3240707 by yutong.li, yas: Hotfix - Fix InvalidArgumentException...

yas closed merge request !439

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs work

@yutong.li

We still have the same errors, so please let us re-open this issue. Could you please refactor as follows?

    $period_options = $this->getPeriodOptions();
    $criteria_options = $this->getCriteriaOptions();
    $hour_options = DateHelper::hours();
    $minute_options = DateHelper::minutes();
    unset($hour_options['']);
    unset($minute_options['']);

Thanks!

yutong.li’s picture

yutong.li commented

@yas
What kind of test should I run so I know if we still see any error?
I kept only the fields related to $hour_options and $minute_options and ran the patch through both drupal test and gitlab CI/CD pipeline and they both returned passed.

yutong.li reopened merge request !439

yutong.li’s picture

yutong.li commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@yutong.li

Thank you for the update. It looks good now. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed 05c8da0 on 4.x authored by yutong.li 
    Issue #3240707 by yutong.li, yas: Hotfix - Fix InvalidArgumentException...

yas closed merge request !439

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.