Hi,
Super helpful module, thanks!

8.x-1.2 version of the module was running fine on 8.9.18, but getting this after upgrade to 8.9.19

TypeError: Argument 1 passed to Drupal\email_blocker\EventSubscriber\SiteExit::terminate() must be an instance of Symfony\Component\HttpKernel\Event\ResponseEvent, instance of Symfony\Component\HttpKernel\Event\FilterResponseEvent given in Drupal\email_blocker\EventSubscriber\SiteExit->terminate() (line 12 of modules/contrib/email_blocker/src/EventSubscriber/SiteExit.php).

Thanks!

(the form for creating an issue requires a version number but `8.x-1.2` was not an option, just to note the discrepancy, if it matters)

Comments

DanStorm created an issue. See original summary.

danstorm’s picture

danstorm commented

oh blurg... looks like 8.x-1.2 was released today and composer updated it without me noticing. I downgraded to 8.x-1.1 and that version of the module is working in core 8.9.19.

So this statement:

"8.x-1.2 version of the module was running fine on 8.9.18"

wasn't accurate. I don't know if 8.x-1.2 works on 8.9.18, but I can say it's throwing an error on 8.9.19 :)

danstorm’s picture

danstorm commented
Title: breaking error after core upgrade to 8.9.19 » TypeError on 8.x-1.2 version
gaurav.kapoor’s picture

gaurav.kapoor commented
Version: 8.x-1.1 » 8.x-1.2

  • gaurav.kapoor authored 2aeacae on 8.x-1.x 
    Issue #3238660 by gaurav.kapoor: TypeError on 8.x-1.2 version
gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Active » Fixed

I noticed that the event subscriber which was throwing an error isn't needed anymore and I have removed it completely in the commit for this issue. Also, did a few minor changes as part of the commit for this issue such as:

1. Fixed email message logging logic and replaced it with logging JSON encode $message in logs instead of printing it.
2. Fixed class description for settings form.
3. Removed undefined core key from the info.yml and thus limiting module usage only to Drupal core version > 8.8.

Adding a new release with a commit for this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.