Problem/Motivation

This module's composer.json restricts installation to PHP7, let's support PHP8 as well!

CommentFileSizeAuthor
#3 3238394-3-test-only.patch252 bytesacbramley
#2 3238394-test-only.patch263 bytesacbramley

Issue fork plugin-3238394

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

acbramley created an issue. See original summary.

acbramley’s picture

acbramley commented
Status: Active » Needs review
StatusFileSize
new 3238394-test-only.patch263 bytes

Let's see what fails

acbramley’s picture

acbramley commented
StatusFileSize
new 3238394-3-test-only.patch252 bytes

Updates composer.json XD

acbramley opened merge request !1

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

LGTM

afi13’s picture

afi13 commented

It would be nice to merge it =)

joachim’s picture

joachim commented
Status: Reviewed & tested by the community » Needs work

TBH I'm not sure why we're specifying a version of PHP anyway!

If it's because the code uses features new in PHP 7.1, that version isn't even supported any more. So we can just remove this line completely.

acbramley’s picture

acbramley commented
Status: Needs work » Needs review

Done.

  • joachim committed c556deb on 8.x-2.x authored by acbramley 
    Issue #3238394: Removed old PHP requirement which was preventing PHP 8.
joachim’s picture

joachim commented
Status: Needs review » Fixed

Thanks!

andypost’s picture

andypost
he/him
Primary language Russian
commented

Please create new release to allow testing on PHP 8.0 and 8.1.1

joachim’s picture

joachim commented

Coming up!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.