Problem/Motivation

In "KPI Analytics" module we have a plugin with incompatible method declaration and got the fatal error: Fatal error: Declaration of Drupal\kpi_analytics\Plugin\KPIDatasource\DrupalContextKPIDatasource::query($query) must be compatible with Drupal\kpi_analytics\Plugin\KPIDatasourceBase::query(Drupal\block_content\BlockContentInterface $entity, $block)



alt

Steps to reproduce

N/A

Proposed resolution

N/A

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
Screenshot 2021-09-09 at 15.12.48.png447.58 KBvnech

Issue fork kpi_analytics-3232124

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vnech created an issue. See original summary.

vnech opened merge request !6

vnech’s picture

vnech commented
Status: Active » Needs review
vnech’s picture

vnech commented
Issue summary: View changes
Status: Needs review » Active

ribel made their first commit to this issue’s fork.

  • ribel committed 252811a on 8.x-1.x authored by vnech 
    Issue #3232124 by vnech: Add compatible with parent parameters to the "...
ribel’s picture

ribel
Primary language Ukrainian
Location 🇺🇦Lviv
commented
Title: Fatal error: Declaration of Drupal\kpi_analytics\Plugin\KPIDatasource\DrupalContextKPIDatasource::query($query) must be compatible with Drupal\kpi_analytics\Plugin\KPIDatasourceBase::query(Drupal\block_content\BlockContentInterface $entity, $block) » Add compatible with parent parameters to the "DrupalContextKPIDatasource" method
Status: Active » Reviewed & tested by the community

The fix was merged.

ribel’s picture

ribel
Primary language Ukrainian
Location 🇺🇦Lviv
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.