Problem/Motivation

Stop low priority containers when K8s resource is getting higher in a cluster

CommentFileSizeAuthor
#8 dev1.dataninja.net_admin_structure_cloud_config_28_edit_destination=_admin_structure_cloud_config&cloud_context=cloudopt_k8s_1(MacBook Air).png354.12 KByas
#6 dev1.dataninja.net_admin_structure_cloud_config_28_edit_destination=_admin_structure_cloud_config&cloud_context=cloudopt_k8s_1.png516.08 KByas

Issue fork cloud-3232055

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan opened merge request !382

xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review

@yas

Please review the commit code. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@xiaohua-guan

Thank you for the patch. It looks great; I posted my comment. Also, could you please double-check the test failures and coding standard violations? Thanks!

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

Thanks for your review. I've fixed them. Please take a look again. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
StatusFileSize
new dev1.dataninja.net_admin_structure_cloud_config_28_edit_destination=_admin_structure_cloud_config&cloud_context=cloudopt_k8s_1.png516.08 KB

@xiaohua-guan

Thank you for the update. Could you please add some description to three fields? Thanks!

k8s_1.png

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

Thanks for your comment. I've fixed it. Please take a look again.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new dev1.dataninja.net_admin_structure_cloud_config_28_edit_destination=_admin_structure_cloud_config&cloud_context=cloudopt_k8s_1(MacBook Air).png354.12 KB

@xiaohua-guan

Thank you for the update. I confirmed the patch and it looks good to me now. I'll merge the patch to 4.x and close this issue as Fixed.

29.png

  • yas committed ef14ec5 on 4.x authored by Xiaohua Guan 
    Issue #3232055 by Xiaohua Guan, yas: Stop low priority containers when...

yas closed merge request !382

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.