Problem/Motivation

If the 5.0.x version of Charts is not set in the dependencies, the module will pull the wrong version of Charts.

Proposed resolution

Set the version for the charts dependency in the info.yml file.

Issue fork charts_twig-3231773

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andileco created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Parent issue: » #3247344: PHP 8.0 compatibility

review also against the latest release

andileco opened merge request !1

  • andileco committed 6bde1ca on 1.0.x 
    Issue #3231773 by andileco, joseph.olstad: Ensure correct version of...
andileco’s picture

andileco commented
andileco’s picture

andileco commented
Status: Active » Fixed
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

cool, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

andileco’s picture

andileco commented
Status: Closed (fixed) » Needs work

Opening this back up to require a non-dev version now that a full 5.x release is out.

andileco opened merge request !2

andileco closed merge request !2

andileco opened merge request !3

andileco’s picture

andileco commented
Status: Needs work » Fixed

Going through merge request hell. Going to close this again and open a new issue.

andileco’s picture

andileco commented
Status: Fixed » Closed (fixed)

andileco closed merge request !3