Problem/Motivation

Show the link of metrics server in warning messages.

Issue fork cloud-3230796

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Xiaohua Guan created an issue. See original summary.

xiaohua guan’s picture

Status: Active » Needs review

@yas

Please review the commit. Thanks.

yas’s picture

Status: Needs review » Needs work

@xiaohua-guan

Thank you for finding and fixing a bug. I think we should add a comment to avoid repeating the same mistake in the future. Thanks!

xiaohua guan’s picture

Status: Needs work » Needs review

@yas

I added the comment. Please check it.

yas’s picture

@xiaohua-guan

Thank you for the update but there is a coding standard violation since my original suggestion of the comment didn't comply with the indents. Could you please fix it?

Thanks!

yas’s picture

Title: Show the link of metrics server in warning messages. » Show the link of metrics server in warning messages
Status: Needs review » Needs work
xiaohua guan’s picture

Status: Needs work » Needs review

@yas

I've fixed the comment. Please check it again. Thanks.

yas’s picture

Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the fix. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed cdbea14 on 4.x authored by Xiaohua Guan
    Issue #3230796 by Xiaohua Guan, yas: Show the link of metrics server in...

yas’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.