Implement calculateDependencies() in FacetsFormBlock.

Issue fork facets_form-3230468

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

saidatom created an issue. See original summary.

saidatom opened merge request !15

saidatom’s picture

saidatom
Location Lisbon
commented
Assigned: saidatom » Unassigned
Status: Active » Needs review
gilmar.lima’s picture

gilmar.lima commented

I've applied this MR to fix an error when importing the form facets block.
MR works as expected.

gilmar.lima’s picture

gilmar.lima commented
Status: Needs review » Reviewed & tested by the community

MR implemented and tested locally, it is working as expected

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Reviewed & tested by the community » Needs work

@saidatom, Great that you've spotted this. @gilmar.lima, than you for testing. Still, I have some remarks, please see the MR.

saidatom’s picture

saidatom
Location Lisbon
commented
Status: Needs work » Needs review
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs review » Reviewed & tested by the community

Thank you, looks good.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.