Problem/Motivation

The content logic is spread out too much using the event subscriber, when most of the logic is already in the module submit handler.

Proposed resolution

clean it up. Patch to come.

CommentFileSizeAuthor
#7 organize_code-3229845-7.patch33.53 KBtonytheferg
#6 organize_code-3229845-6.patch32.31 KBtonytheferg
#5 organize_code-3229845-5.patch27.71 KBtonytheferg
#4 organize_code-3229845-4.patch22.52 KBtonytheferg
#3 organize_code-3229845-3.patch21.72 KBtonytheferg
#2 organize_code-3229845-2.patch18.14 KBtonytheferg

Comments

tonytheferg created an issue. See original summary.

tonytheferg’s picture

tonytheferg commented
Status: Active » Needs review
StatusFileSize
new organize_code-3229845-2.patch18.14 KB

Here is a patch to remove the overkill dual event subscriber and an added helper function to clean up the code.

Also fixes and improves some stuff with the close commands.

tonytheferg’s picture

tonytheferg commented
StatusFileSize
new organize_code-3229845-3.patch21.72 KB

Some more work on close button config and some more cleanup.

tonytheferg’s picture

tonytheferg commented
StatusFileSize
new organize_code-3229845-4.patch22.52 KB

Bad patch

tonytheferg’s picture

tonytheferg commented
Title: Better organize the code. » Organize the code, and add cart and close buttons
StatusFileSize
new organize_code-3229845-5.patch27.71 KB

lots of config for view cart and close buttons.

tonytheferg’s picture

tonytheferg commented
Title: Organize the code, and add cart and close buttons » Organize the code, and add cart and close buttons, and message config
StatusFileSize
new organize_code-3229845-6.patch32.31 KB

added a start on message config. getting close.

tonytheferg’s picture

tonytheferg commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new organize_code-3229845-7.patch33.53 KB

I think this is good. Going to commit.

  • tonytheferg committed db16d17 on 1.0.x 
    Issue #3229845 by tonytheferg, mglaman, ericchew: Organize the code, and...
tonytheferg’s picture

tonytheferg commented
Status: Reviewed & tested by the community » Fixed
tonytheferg’s picture

tonytheferg commented
Status: Fixed » Closed (fixed)