Replace the hard-coded error messages with configurable ones.

Consider the UX of the settings form when doing so.

Issue fork advanced_email_validation-3228659

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Darvanen created an issue. See original summary.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Title: Make error messages configurable » Make error messages configurable and translatable.
Assigned: Unassigned » darvanen

Planning on following this guide: https://antistatique.net/en/blog/drupal-8-how-to-translate-the-config-api

darvanen opened merge request !2

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Active » Needs review

Tested translatability with the config_translate module in core. Works nicely!

There's a massive gotcha where the translation system gives a 403 if there's nothing configured to be translatable. Going to search for/create a follow-up in core for that.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented

Hello there single follower of this issue other than me... whoever you are.

Might I interest you in testing this change out? I don't really have anything to offer except commit credit :)

Note there are breaking changes - if you do this you'll need to uninstall and reinstall.

  • darvanen committed 90f8b8a on 1.0.x 
    Issue #3228659: Make error messages configurable and translatable.
darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Assigned: darvanen » Unassigned
Status: Needs review » Fixed

Silly me, that's what the module is in alpha for :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.