Problem/Motivation

The codes pool csv table requires an index for increased performance once the upload table gets to a large size.

Proposed resolution

Add an index based on entity_id then status.

Data model changes

Add an index based on entity_id then status.

CommentFileSizeAuthor
#9 codes_pool-add-entity_id_status-index-3228627-9.patch2.31 KBkschisler
#5 codes_pool-add-entity_id_status-index-3228627-5.patch1.65 KBdavenelson
#2 codes_pool-3228627-2_0.patch1.46 KBkschisler

Comments

EvanSchisler created an issue. See original summary.

kschisler’s picture

kschisler commented
StatusFileSize
new codes_pool-3228627-2_0.patch1.46 KB
kschisler’s picture

kschisler commented
Status: Active » Needs review
vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs review » Needs work

Over all looks good. just need to update the update hook:

+++ b/codes_pool.install
@@ -0,0 +1,24 @@
+  $table = 'codes_pool_csv_default';

We need to pull all CSV budles and update them. Here we are updating just a bundle default

davenelson’s picture

davenelson commented
StatusFileSize
new codes_pool-add-entity_id_status-index-3228627-5.patch1.65 KB
vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs work » Reviewed & tested by the community

Thanks, @davenelson. It looks good.

kschisler’s picture

kschisler commented
Status: Reviewed & tested by the community » Needs work

Would like to see this rerolled to add a check for existing indexes as well as a new index added against code.

Patch incoming

vijaycs85’s picture

vijaycs85
Location London, UK
commented

Thanks, @EvanSchisler.

kschisler’s picture

kschisler commented
Status: Needs work » Needs review
StatusFileSize
new codes_pool-add-entity_id_status-index-3228627-9.patch2.31 KB

  • vijaycs85 committed 47976da on 8.x-2.x 
    Issue #3228627 by EvanSchisler, davenelson, vijaycs85: Add...
vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs review » Fixed

Thank you. committed to 8.x-2.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.