On a fresh install of Drupal 9.2.3 with mmenu Version 8.5.24,the status page reports:
"Library not installed
The mmenu library must be installed at /libraries/mmenu and must be version 8.4.0 or greater. "
This menu still seems to work OK.
This is also noted by others on
https://www.drupal.org/project/responsive_menu/issues/3059887#comment-14...
https://www.drupal.org/project/responsive_menu/issues/3059887#comment-14...
I get the same behaviour, v8.5.23 works fine, v8.5.24 and the "Library not installed..." is back.
I'm not sure how Drupal detects the library and version.
Nothing jumps out at me when I compare the versions:
https://github.com/FrDH/mmenu-js/compare/v8.5.23...v8.5.24
Any suggestions?
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
finn lewisStill confused by the issue forking, but I've changed the hook_requirements(). to use the package.json rather than the composer.json (which has been removed in 8.5.24) so the error is gone.
But not sure if my fork represents the patch change needed.
See https://git.drupalcode.org/issue/responsive_menu-3227906/-/merge_requests/1
Comment #4
tancThanks Finn! This change looks like its now picking up the
package.jsonfile and I'm not seeing any errors in the tugboat preview. It might be good to confirm it works as intended by downloading an old version of mmenu library and confirming the version requirement match fails. I think the minimum supported version is 8.4.x so you could download and test 8.3.xIt is also important to check that existing installs with a slightly older mmenu don't throw the warning, so confirming that mmenu version 8.5.23 and below (but not below 8.4.0) work without showing a warning on the status page. I had a quick look at the older versions and they seem to have
package.jsonwith a version string so should be fine, but worth checking.Comment #5
finn lewisWith mmenu 8.3.0 I get:
Version 8.3.0 is installed but 8.4.0 is required
The mmenu library must be installed at /libraries/mmenu and must be version 8.4.0 or greater. The download url is https://github.com/FrDH/mmenu-js/releases/latest
With mmenu 8.4.8 and 8.5.22 no errors and it reports the correct version.
Comment #6
gauravjeet commentedHi tanc,
I have installed this module version 4.4.1 and can confirm that there's a version error on the Status Report page.
This patch fixes it!
Comment #7
gauravjeet commentedComment #8
finn lewisThanks @gauravjeet !
I think this might be RTBC, what do you think @tanc
Comment #10
tancThank you all, this is now committed on the develop branch
Comment #11
finn lewisThanks Tanc!