Closed (fixed)
Project:
helpfulness
Version:
2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
11 Aug 2021 at 14:40 UTC
Updated:
26 Aug 2021 at 18:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
leonardpg commentedPatch attached. Small changes to src/Form/HelpfulnessBlockForm.php to add the page url to the params array, and helpfulness.module to append the 'nodeurl' to the body of the email in helpfulness_mail.
Comment #3
leonardpg commentedPatch attached. Small changes to src/Form/HelpfulnessBlockForm.php to add the page url to the params array, and helpfulness.module to append the 'nodeurl' to the body of the email in helpfulness_mail. (Resubmitting. I forgot to change the status to 'needs review'.)
Comment #4
gueguerreiroHello @leonardpg, thank you for opening the issue and providing a patch! The change makes total sense to me. I'll commit it and create new releases for 8.x and 2.x versions of the module.
A little nitpick, but I'm changing the variable name from "nodeurl" to "page_url", as that's more technically correct, since the helpfulness block doesn't necessarily have to be placed on a node page (It can be placed on a taxonomy page, or a view page, for example). I can just do that directly though, I won't ask you to provide a new patch for such a small change.
Comment #7
gueguerreiroCommitted your changes to both D8 branches and created new releases. Thanks for making this module better for everyone!