Problem/Motivation

In #3027952: [Plan] Remove the usage of deprecated methods in tests, we removed usage and started triggering deprecation errors for legacy assert methods coming from Simpletest.

It's time to remove the legacy traits for D10.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

None

CommentFileSizeAuthor
#6 reroll_diff_3-6.txt2.33 KBmurilohp
#6 3227265-6.patch85.63 KBmurilohp
#3 3227265-3.patch85.63 KBmondrake
#2 3227265-2.patch85.4 KBmondrake

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Postponed
StatusFileSize
new 3227265-2.patch85.4 KB
mondrake’s picture

mondrake
Location 🇮🇹
commented
StatusFileSize
new 3227265-3.patch85.63 KB
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Postponed » Active
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs work
Issue tags: +Needs reroll
murilohp’s picture

murilohp commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 3227265-6.patch85.63 KB
new reroll_diff_3-6.txt2.33 KB

Hey @mondrake, I rerolled the #3 into branch 10.0.x.

Thanks!

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community

8 files changed, 0 insertions, 1795 deletions.

What a cleanup!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed e0f297b and pushed to 10.0.x. Thanks!

  • alexpott committed e0f297b on 10.0.x 
    Issue #3227265 by mondrake, murilohp: Remove the legacy assert traits
catch’s picture

catch
he/him
Primary language English
commented
Status: Fixed » Active

Discussed with @alexpott and @Gábor Hojtsy in slack - something like 70% of deprecations found in Drupal 9-compatible modules are Drupal 8 deprecations (which probably means these), so even though this is deprecated in 8 for 9, we should still only remove it after alpha1. Re-opening for a revert. We should be good to recommit once alpha1 is tagged though.

  • catch committed bff7184 on 10.0.x 
    Revert "Issue #3227265 by mondrake, murilohp: Remove the legacy assert...
catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Reviewed & tested by the community

Done the revert for now, back to RTBC.

  • catch committed 2a740bf on 10.0.x authored by alexpott 
    Issue #3227265 by mondrake, murilohp: Remove the legacy assert traits
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Cherry-picked back the original commit, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.