Problem/Motivation

It is not possible to override the location of the binaries using settings.php

Steps to reproduce

If the binaries are in a location other than /usr/bin, add the following to an included settings.local.php file

$config['php_ffmpeg.settings']['ffmpeg_binary'] = '/var/www/custom_location/ffmpeg';
$config['php_ffmpeg.settings']['ffprobe_binary'] = '/var/www/custom_location/ffprobe';

The location for the binaries is still derived from the module settings rather from the overridden config set in the settings.php file.

Proposed resolution

Change the constructor of the PHPFFMpegFactory calss to use the 'get' method of the config factory rather than 'getEditable'.

Issue fork php_ffmpeg-3225830

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

AlanHDev created an issue. See original summary.

alanhdev’s picture

Assigned: alanhdev » Unassigned
Status: Active » Needs review
alanhdev’s picture

Issue summary: View changes
flyke’s picture

I can confirm this works.

Berdir made their first commit to this issue’s fork.

  • Berdir committed c7a30f27 on 8.x-1.x authored by AlanHDev
    Issue #3225830: Unable to override settings in settings.php
    
berdir’s picture

Status: Needs review » Fixed

Makes sense, merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.