Problem/Motivation
- Check and align the comments at
Drupal\k8s\Plugin\views\field\K8s<ResourceName>BulkForm - The following is a list of CamelCase resource names (the other one is NOT CamelCame):
ConfigMapsCronJobDaemonSetLimitRangeReplicaSetServiceAccountStatefulSet
- See also the Glossary page: https://kubernetes.io/docs/reference/glossary/?all=true
- Format:
/** * Defines a ReplicaSet operations bulk form element. * * @ViewsField("<resource_name>_bulk_form") */ class K8s<ResourceName>BulkForm extends BulkForm { /** * {@inheritdoc} */ protected function emptySelectedMessage(): TranslatableMarkup { return $this->t('No <Resource Name> selected.'); } } - For example:
/** * Defines a ReplicaSet operations bulk form element. * * @ViewsField("replica_set_bulk_form") */ class K8sReplicaSetBulkForm extends BulkForm { /** * {@inheritdoc} */ protected function emptySelectedMessage(): TranslatableMarkup { return $this->t('No ReplicaSet selected.'); } }/** * Defines a Network Policy operations bulk form element. * * @ViewsField("network_policy_bulk_form") */ class K8sNetworkPolicyBulkForm extends BulkForm { /** * {@inheritdoc} */ protected function emptySelectedMessage(): TranslatableMarkup { return $this->t('No Network Policy selected.'); }
Issue fork cloud-3225420
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3225420-align-the-comments
changes, plain diff MR !391
Comments
Comment #2
yasComment #4
TamakiFujino commentedComment #6
TamakiFujino commentedComment #7
yas@tamakifujino
Thank you for the refactoring. It looks good. I'll merge the patch to
4.xand close this issue as Fixed.Comment #10
yas