Problem/Motivation

Somehow, somewhere, an incorrect indentation slipped into /core/modules/tour/src/TourViewBuilder.php which now results in any change in that file being rejected by TestBot.

FILE: /var/www/html/core/modules/tour/src/TourViewBuilder.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 74 | ERROR | Comment indentation error, expected only 1 spaces
    |       | (Drupal.Commenting.InlineComment.SpacingBefore)
 78 | ERROR | Comment indentation error, expected only 1 spaces
    |       | (Drupal.Commenting.InlineComment.SpacingBefore)
----------------------------------------------------------------------

This was first spotted by @quietone here and confirmed by @daffie here.

Steps to reproduce

- Change something in /core/modules/tour/src/TourViewBuilder.php
- Create a patch/MR with that change
- See TestBot reject the patch in the Custom Commands phase

Proposed resolution

Attached MR should fix the indentation problems.

Remaining tasks

- Review
- Commit
- Rejoice

Issue fork drupal-3224861

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !966

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review

MR should fix the indentation problem.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

RTBC if bot agrees.

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 9.3.x-dev » 9.2.x-dev
Category: Bug report » Task
Status: Reviewed & tested by the community » Fixed

Committed and pushed 38c6162c0e to 9.3.x and 2f09626f10 to 9.2.x. Thanks!

Not really sure that this is a bug fix. It doesn't result in a broken site or anything.

  • alexpott committed 38c6162 on 9.3.x 
    Issue #3224861 by Spokje: PHPCS failure in /core/modules/tour/src/...

  • alexpott committed 2f09626 on 9.2.x 
    Issue #3224861 by Spokje: PHPCS failure in /core/modules/tour/src/...

Spokje closed merge request !966

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.