Problem/Motivation

  • Let users select Terraform, Openstack, VMware during installation
CommentFileSizeAuthor
#5 Additional_configurations___Cloud_Orchestrator.png1.37 MBbaldwinlouie

Issue fork cloud_orchestrator-3224732

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

baldwinlouie created an issue. See original summary.

baldwinlouie opened merge request !11

baldwinlouie’s picture

baldwinlouie commented
Status: Active » Needs review

@yas. This PR adds the ability to enable Terrform, VMware and OpenStack. I've decided to make AWS Cloud and K8s enabled by default because we use the two tabbed dashboard as the homepage.

This way, it simplifies the code in submitForm in ModuleConfigureForm

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Let users select Terraform, Openstack, Vmware during installation » Let users select Terraform, Openstack, VMware during installation
Issue summary: View changes

@baldwinlouie

Thank you for the patch. I tested the patch and it works fine, and I feel that we should add AWS and K8s options during the installation like before because as an IT admin, it would be easier to recognize which modules are being installed. In that case, I think the AWS and K8s checkbox are disabled.

What do you think?

baldwinlouie’s picture

baldwinlouie commented
StatusFileSize
new Additional_configurations___Cloud_Orchestrator.png1.37 MB

@yas, I added a set of "disabled" checkboxes to show the user that AWS and K8s are already enabled. The disabled checkboxes do not do anything because the modules are enabled once the Install Profile is installed. They are there merely for UI/UX.

Please see screenshot and the PR.

See this screenshot.

I split it up into its own set of checkboxes because
1. Easier to implement than adding them to the Checkboxes with OpenStack/VMware/Terraform. It would have been harder to disable AWS and K8s if I put them there.
2. Technically, AWS/K8s are already enabled once the Install Profile is enabled, since those modules were part of the cloud_orchestrator.info.yml

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for the update. It looks good. I'll merge the patch to 3.x and 4.x, and close this issue as Fixed.

  • yas committed 47a5b92 on 3.x authored by baldwinlouie 
    Issue #3224732 by baldwinlouie, yas: Let users select Terraform,...

  • yas committed 3019c2d on 4.x authored by baldwinlouie 
    Issue #3224732 by baldwinlouie, yas: Let users select Terraform,...

yas closed merge request !11

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.