I think there is a development-only method leftover on the NotificationMessageBlock:
/**
* {@inheritDoc}
*/
public function getCacheMaxAge() {
return 0;
}
This means that any page which has this blocked placed on it, whether there are notification messages to be displayed or not, becomes immediately uncacheable.
None.
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | cleanup.patch | 2.38 KB | gabesullice |
| #7 | 3224578-7-block-cacheability.patch | 13.16 KB | gabesullice |
| #7 | 3224578-7-block-cacheability-TEST-ONLY.patch | 6.28 KB | gabesullice |
| #7 | interdiff.txt | 1.62 KB | gabesullice |
Comments
Comment #2
gabesulliceThis patch is combined with #3222678: Add BrowserTest for viewing a notification message as an anonymous visitor. I'll post another patch that can be applied after that one is committed that will not conflict.
Comment #3
gabesulliceOnce #3222678: Add BrowserTest for viewing a notification message as an anonymous visitor lands, the attached patches should apply and you should be able to run tests on them to confirm that they work as expected.
You'll notice that I left a TODO in the test. I started trying to debug why the second "path-specific" message is not displaying, but it seems to be unrelated to caching, so I stopped because I ran out of time. The test that is not commented out still shows that this attached patch fixes the reported problem in the issue summary though.
Note: these will both fail to apply until the other issue is committed. They can be retested after it is.
Comment #4
gabesulliceWhoops, looks like what I wrote isn't compatible with that version of PHP.
FAIL & COMBINED should fail and pass tests. They contain the patch in the other issue.
TEST-ONLY and .patch won't apply, but they should fail and pass when the other issue lands.
Comment #6
gabesulliceRerolling and retesting now that #3222678: Add BrowserTest for viewing a notification message as an anonymous visitor has been committed.
Comment #7
gabesulliceWhoops, had to remove some PHP 8 only syntax.
Comment #10
gabesulliceCleaned up a couple CS violations on commit.