New features and patch combine / reroll

Thanks for this. Working great for me.

It also works for me on D9.

Just a small improvement. I updated the helper text to this one below, to make sure people understand the complication.

This could potentially lead to GDPR / PII data problems. e.g. An anonymous user placed an order but made a typo in the email address, this order could be assigned to another user by mistake. Then, the second user could see the personal information of the first user.

Forgot to add new files in the previous patch file

The #2 patch works for me. I can't upgrade to Drupal 9 from Drupal 8 without removing the module from composer and re-adding it after.

Plus 1 to get this committed!

There is a bug on the config form:

$form['assign_to_existing'] = [
  '#type' => 'checkbox',
  '#title' => $this->t('Assign orders to existing accounts'),
  '#default_value' => $config->get('create_new'),
  '#description' => $this->t('This could potentially lead to GDPR / PII data problems. e.g. An anonymous user placed an order but made a typo in the email address, this order could be assigned to another user by mistake. Then, the second user could see the personal information of the first user.'),
  '#weight' => '0',
];

Where it should be:

$form['assign_to_existing'] = [
  '#type' => 'checkbox',
  '#title' => $this->t('Assign orders to existing accounts'),
  '#default_value' => $config->get('assign_to_existing'),
  '#description' => $this->t('This could potentially lead to GDPR / PII data problems. e.g. An anonymous user placed an order but made a typo in the email address, this order could be assigned to another user by mistake. Then, the second user could see the personal information of the first user.'),
  '#weight' => '0',
];

Re-roll of patch #6 with the fix above and applied coding standards and best practices.

./vendor/bin/drupal-check web/modules/custom/commerce_guest_registration/
<be>
 4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


 [OK] No errors

 /vendor/bin/phpcs -p --standard="DrupalPractice" --ignore=*/vendor/*,*/bootstrap/*,*/tests/*,*/.gitlab-ci/*,Readme.md,style.css,print.css,*Test.php,RoboFile.php "web/modules/custom/commerce_guest_registration/" --extensions=php,inc,module,install,test,profile,them
... 3 / 3 (100%)


Time: 83ms; Memory: 4MB

./vendor/bin/phpcs -p --standard="Drupal" --ignore=*/vendor/*,*/bootstrap/*,*/tests/*,*/.gitlab-ci/*,Readme.md,style.css,print.css,*Test.php,RoboFile.php "web/modules/custom/commerce_guest_registration/" --extensions=php,inc,module,install,test,profile,them
... 3 / 3 (100%)


Time: 143ms; Memory: 6MB

I believe we can commit this and release a 2.0.0 version of the module for Drupal 9.

I am trying to pull your MR version via composer.json to do a test but I keep getting an error:

composer 2.25

Problem 1
- Root composer.json requires drupal/commerce_guest_registration dev-custom#b4481e7a207cee63b0da9b33105891907f19db6f, it is satisfiable by drupal/commerce_guest_registration[dev-custom] from package repo (defining 1 package) but drupal/commerce_guest_registration[dev-1.x, 1.0.0, 1.x-dev (alias of dev-1.x)] from composer repo (https://packages.drupal.org/8) has higher repository priority. The packages from the higher priority repository do not match your constraint and are therefore not installable. That repository is canonical so the lower priority repo's packages are not installable. See https://getcomposer.org/repoprio for details and assistance.

I added "canonical": false, as shown below.

 under require  "drupal/commerce_guest_registration":"dev-custom#b4481e7a207cee63b0da9b331\
05891907f19db6f",

	"repositories": [
        {
            "type": "composer",
	    "url": "https://packages.drupal.org/8",
	    "canonical": false,
            "exclude": [
                "drupal/commerce_guest_regsitration",
                "drupal/group_webform",
                "drupal/webform_dropzonejs"
	    ]

and the repositories:

	{
            "type": "package",
            "package": {
                "name": "drupal/commerce_guest_registration",
                "type": "drupal-module",
		"version": "dev-custom",
                "source": {
                    "type": "git",
                    "url": "git@git.drupal.org:issue/commerce_guest_registration-3\
224303.git",
	            "reference": "3224303-new-features-and"
                }
	    }
        },