Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
The following error is present on validate() even if the setting is enabled.
Enable this option to store all files as private files in S3. To enable this feature include the following in settings.php:
Important:If you enable this feature you can't enable 'use_s3_for_public'.
\$settings['s3fs.upload_as_private'] = TRUE;"
Steps to reproduce
Bucket that does not allow public files run a config validation test.
Proposed resolution
in validate() check for s3fs.upload_as_private instead of looking at the config array passed in.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | interdiff-3223654-3-7.txt | 2.21 KB | cmlara |
| #7 | upload_as_private_no-3223654-7.patch | 2.74 KB | cmlara |
| #3 | validate_does_not_ge-3223654-2.patch | 538 bytes | cmlara |
Comments
Comment #3
cmlaraLooks like this occurred when working on #3185760: Allow read only use of S3 bucket
I'm guessing I thought that we would be passing in the config setting as part of the validation (because its on the form) forgetting that the form doesn't get directly passed only the config array gets passed.
I'm going to be looking forward to 4.x when everything is part of the config entity....
Comment #4
cmlaraComment #6
cmlaraOpening this bug up a bit more as its actually bigger than first seen.
S3fsFileService was directly copied S3fsFileMigrationBatch so it makes sense that this error would exist in both locations.
Root Fault Analysis:
It appears that somewhere along the lines I started thinking that this value was passed around as part of the configuration instead of with settings and that error propagated through the rest of the code. This possibly may have been caused by the fact it shows up in the constructor of S3fsStreamWrapper as part of the configuration array. In either case it was ultimately caused by copying the same code into multiple places.
Once fixed this will trigger a Beta2 due to severity.
Comment #7
cmlaraComment #10
cmlara