Problem/Motivation

With Drupal 8.9.16, the Widget Engine module in version 1.3 raises a fatal error because the method signature of isPublished() does not conform to the expected one.

Fatal error: Declaration of Drupal\widget_engine\Entity\Widget::setPublished($published) must be compatible with Drupal\Core\Entity\EditorialContentEntityBase::setPublished($published = NULL) in /var/www/html/docroot/modules/contrib/widget_engine/src/Entity/Widget.php on line 72

Steps to reproduce

Install Widget Engine in version 1.3 with Drupal 8.9.16.

Proposed resolution

It is necessary to adapt the method signature so that it can be compatible with the one described in EditorialContentEntityBase::setPublished.

CommentFileSizeAuthor
#7 3221502.patch852 bytesrowen92

Issue fork widget_engine-3221502

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tido created an issue. See original summary.

tido’s picture

tido
Location Montpellier
commented

I have the impression that the method signature problem has been solved in patch #16 of this issue:
https://www.drupal.org/project/widget_engine/issues/3071378.

Is it planned to be merged soon? Either patch #16 or #17. From what I see it doesn't pass validation tests on Drupal 8.9.x

shumer’s picture

shumer commented
Assigned: Unassigned » shumer

  • tido authored 4520f50 on 8.x-1.x 
    Issue #3221502 by tido, shumer: Declaration of Widget::setPublished not...
shumer’s picture

shumer commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rowen92’s picture

rowen92 commented
StatusFileSize
new 3221502.patch852 bytes

Let's have a separate patch that can resolve this issue unless it's fixed there #3071378.