Problem/Motivation

Change the class name from CloudServerTemplate to CloudLaunchTemplate (Cloud)

Issue fork cloud-3221415

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sekinet created an issue. See original summary.

sekinet opened merge request !291

yas made their first commit to this issue’s fork.

sekinet’s picture

sekinet commented
Status: Active » Needs review

@yas

I've created the patch. Could you please check it?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@sekinet

Thank you for the great patch.

@all

What do you think?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Change the class name from CloudServerTemplate to CloudLaunchTemplate (Cloud) » Change the class name from CloudServerTemplate to CloudLaunchTemplate
baldwinlouie’s picture

baldwinlouie commented

@yas and @sekinet,

Thank you for the patch. I have the following general comment.

Do we need a hook_update_N function in `cloud.install` to update existing instances after they update their codebase with this feature? See cloud_update_8110() and cloud_update_8149() and cloud_update_8150(). Hopefully, we just need to run something like cloud_update_8150() to clear out the cached entity definitions.

What do you think?

sekinet’s picture

sekinet commented

@baldwinlouie @yas
Thank you for your comment.
I added cloud_update_8152() which clears the cached entity definitions.
Could you please check it?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@sekinet @baldwinlouie

I posted my minor comments. Could you please check the ones? Thanks

sekinet’s picture

sekinet commented
Status: Needs work » Needs review

@yas
Thank you for your comments. I have fixed it, could you please check?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@sekinet

Thank you for the update. It looks good to me now.

@baldwinlouie

What do you think?

Thanks

baldwinlouie’s picture

baldwinlouie commented

@sekinet, Thank you for the update. It looks good to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for your review and your comment.

@sekinet

Thank you for the update. It looks good, so I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed 37b6265 on 4.x authored by sekinet 
    Issue #3221415 by sekinet, yas, baldwinlouie: Change the class name from...

yas closed merge request !291

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3197051: Change the class name from CloudServerTemplate to CloudLaunchTemplate (Cloud), +#3192691: Change the class name from CloudServerTemplate to CloudLaunchTemplate (AWS Cloud), +#3192692: Change the class name from CloudServerTemplate to CloudLaunchTemplate (K8s), +#3222502: Change the namespace from cloud_server_template to cloud_launch_template

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.