Problem/Motivation

  • Fix and test case issues in AwsCloudConfigTest::testCloudConfig()
  • Refactor test case issues in AwsCloudConfigTest::testAwsMenu()
  • Refactor a test case of AwsCloudConfigTest::testCloudConfigPermissionsValidate()
  • Fix some errors Undefined array key while testing AwsCloudConfigTest
    There were 2 errors:

1) Drupal\Tests\aws_cloud\Functional\cloud\config\AwsCloudConfigTest::testCloudConfigUndefined array key 1

/var/www/html/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/tests/src/Functional/cloud/config/AwsCloudConfigTest.php:191/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:722

2) Drupal\Tests\aws_cloud\Functional\cloud\config\AwsCloudConfigTest::testAddCloudServiceProviderWithWarningUndefined array key 1

/var/www/html/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/tests/src/Functional/cloud/config/AwsCloudConfigTest.php:574/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:722

ERRORS!Tests: 5, Assertions: 193, Errors: 2.

Issue fork cloud-3220987

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yas created an issue. See original summary.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes

yas opened merge request !284

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Active » Needs review

@sekinet @kumikoono

I fixed some issues and refactored the test cases. Could you please review the patch? Thanks

kumikoono’s picture

kumikoono commented

@yas Overall, the patch looks good to me. I left some comments.

sekinet’s picture

sekinet commented

@yas

It looks good to me. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@sekinet

Thank you for your review.

@kumikoono

I added the comment for CloudConfigInterface::MAX_NAME_LENGTH. What do you think?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@kumikoono

Thank you for your review. I removed the specific number 31. Please check. Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@kumikoono

Thank you for your review. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed 72ab62f on 4.x 
    Issue #3220987 by yas, kumikoono, sekinet: Refactor and fix issues of...

yas closed merge request !284

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.