Problem/Motivation

Fix TypeError: Drupal\k8s\Entity\K8sDeployment::getCreationYaml()

Issue fork cloud-3220258

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan opened merge request !277

yas made their first commit to this issue’s fork.

xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review

@yas

Please review the code. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for fixing the issue. It looks good. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed 57dfc13 on 4.x authored by Xiaohua Guan 
    Issue #3220258 by Xiaohua Guan, yas: Fix TypeError: Drupal\k8s\Entity\...

yas closed merge request !277

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

yas reopened merge request !277

yas closed merge request !277

  • yas committed 57dfc13 on cloud-3220258/3220258-2 authored by Xiaohua Guan 
    Issue #3220258 by Xiaohua Guan, yas: Fix TypeError: Drupal\k8s\Entity\...

yas opened merge request !278

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs work

@xiaohua-guan

Please let us re-open this issue since we still have the error. The patch didn't fix the problem :(

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review

Changing to Needs review.

xiaohua guan’s picture

xiaohua guan commented
Status: Needs review » Reviewed & tested by the community

@yas

It looks good to me. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@xiaohua-guan

Thank you for your review. I think the test failures come from the other potential issue. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed d2003d7 on 4.x 
    Issue #3220258 by yas, Xiaohua Guan: Hotfix - Fix TypeError: Drupal\k8s\...

yas closed merge request !278

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.