Problem/Motivation

Some of the results from "json_decode" are treated as objects, but as the second parametre is set to TRUE, they're actually an array. This provokes a chain of errors of undefined properties when trying to do some operations, like syncing roles.

We can see that change comparing to legacy code here: https://git.drupalcode.org/project/discourse_sso/-/compare/8.x-1.0-beta2... (then see all "json_decode" calls.

Steps to reproduce

Install and configure the module.
Edit a user's roles

See attached images:
* https://www.drupal.org/files/issues/2021-06-18/Screenshot%202021-06-18%2...
* https://www.drupal.org/files/issues/2021-06-18/Screenshot%202021-06-18%2...

Proposed resolution

Adapt code reading the results to either object (casting the result array) or array format.

Remaining tasks

Provide patch.

CommentFileSizeAuthor
#2 3219570-2-object_vs_array.patch1.8 KBfjgarlin
Screenshot 2021-06-18 at 15.25.52.png127.5 KBfjgarlin
Screenshot 2021-06-18 at 15.25.29.png57.96 KBfjgarlin

Issue fork discourse_sso-3219570

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fjgarlin created an issue. See original summary.

fjgarlin’s picture

fjgarlin commented
Status: Active » Needs review
StatusFileSize
new 3219570-2-object_vs_array.patch1.8 KB

Patch supplied.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented

@fjgarlin would you mind turning this into an issue fork and merge request? We could then hopefully find somebody who eventually does the review so that we can merge this in.

fjgarlin opened merge request !1

fjgarlin’s picture

fjgarlin commented

You got it @jurgenhaas. Here it is: https://git.drupalcode.org/project/discourse_sso/-/merge_requests/1

  • jurgenhaas committed 154ad65 on 2.0.x authored by fjgarlin 
    Issue #3219570 by fjgarlin: Mix up between objects and arrays due to...
jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Needs review » Fixed

This is great, thanks a lot @fjgarlin

I looked through the MR an it looks great so that I merged it right away. I don't have any discourse instance running any longer, so I'm probably not the ideal maintainer, as I can't test things. But committing and merging is no problem.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.