Problem/Motivation

No test coverage for context with the context all/context any condition.

Proposed resolution

Write a test for it.

Remaining tasks

1. Write a test.
2. Check/test that automated test passes.
3. Review and commit/merge the issue.

Issue fork context-3217118

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DeaOm created an issue. See original summary.

DeaOm opened merge request !16

deaom’s picture

deaom commented
Issue summary: View changes
Status: Active » Needs review

Added the test for context any/all condition with a test module that has a test configuration added for two contexts. Added the missing schema for context any/all condition. I also corrected the context any asterisks condition which was returning false instead of true. Marking this as needs review.

deaom’s picture

deaom commented
Issue summary: View changes
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs review » Needs work

Tests fail when triggered with Drupal 9.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs work » Needs review
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented

  • paulocs committed 7d53e4c on 8.x-4.x authored by DeaOm 
    Issue #3217118 by DeaOm, paulocs: Add test for context Any/All condition
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs review » Fixed
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Fixed » Needs review

One more change need to be addressed.
The core key should be removed from the test module and core_version_requirement should be inserted.

  • paulocs committed 1bc7ae3 on 8.x-4.x 
    Issue #3217118 by paulocs, DeaOm: Add test for context Any/All condition
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.