Split off from #3192274: D7: Upgrade to v2.0.0 and add parameters

We would like to take advantage of some of the new performance gains and options in Quicklink v2.0.0. Also, we are facing some of the same issues identified here due to the module adding more overhead than we would like: https://www.drupal.org/project/quicklink/issues/3145964

CommentFileSizeAuthor
#9 3215288-9.patch45.71 KBmherchel
#8 3215288-8.patch30.55 KBmherchel
#7 3215288-7.patch28.07 KBmherchel
#6 interdiff-5-6.txt16.1 KBmherchel
#6 3215288-6.patch18.89 KBmherchel
#5 3215288-5.patch12.4 KBmherchel
#5 interdiff-2-5.txt6.37 KBmherchel
#2 quicklink-upgrade_add_parameters-4.patch11.81 KBmherchel

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
StatusFileSize
new quicklink-upgrade_add_parameters-4.patch11.81 KB

Attached is the patch from #3192274-4: D7: Upgrade to v2.0.0 and add parameters by @InaW

mherchel credited InaW.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Active » Needs review
StatusFileSize
new interdiff-2-5.txt6.37 KB
new 3215288-5.patch12.4 KB

Fixed some issues in the patch and also updated to 2.1.0

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
StatusFileSize
new 3215288-6.patch18.89 KB
new interdiff-5-6.txt16.1 KB

✅ Tests passing
✅ Fixed schema
✅ Renamed "Parameters" to "Throttle Options"
✅ Moved URLs to a "Prefetch Only" tab
🟩 Test coverage for throttle options
🟩 Add support for options.delay
🟩 URLs should not be in settings.quicklink.quicklinkConfig anymore
🟩 Debug log doesn’t reflect when ignoring file extensions
🟩 Add feature to ignore selectors
🟩 Debug log doesn’t reflect when ignoring ajax links

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
StatusFileSize
new 3215288-7.patch28.07 KB

✅ Test coverage for throttle options
✅ Add support for options.delay
✅ URLs should not be in settings.quicklink.quicklinkConfig anymore
🟩 Debug log doesn’t reflect when ignoring file extensions
✅ Add feature to ignore selectors
🟩 Test coverage for feature to ignore selectors
🟩 Debug log doesn’t reflect when ignoring ajax links

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
StatusFileSize
new 3215288-8.patch30.55 KB

✅ Test coverage for feature to ignore selectors

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
StatusFileSize
new 3215288-9.patch45.71 KB

This is the final patch for the 2.0 dev release.

✅ Added hook update
✅ disabled polyfill by default
✅ Tests that ensure that JS isn't loaded when quicklink or debug mode isn't enabled.
✅ Test that quicklink isn't enabled on content types where it is disabled.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Fixed

Committed to 2.0.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.