Problem/Motivation

Chaos Tool Suite (ctools) - Moderately critical - Information disclosure - SA-CONTRIB-2021-009

Security Advisory likely affects wxt 3x and also wxt 4x

Proposed resolution

upgrade ctools to version 3.6
apply patches in this issue for wxt 3x and 4x, composer up drupal/ctools; add updated composer.lock tag and release.

Remaining tasks

remove conflicting patch #2874176-2: Incorrect cache metadata for EntityView block
https://www.drupal.org/files/issues/entityview-cache-metadata-2874176-2....
set ctools to version 3.6

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

Issue summary: View changes
colan’s picture

Issue summary: View changes

Added missing links to the SA and issue comment.

colan’s picture

Version: 8.x-3.x-dev » 4.0.x-dev
Priority: Normal » Major
StatusFileSize
new784 bytes

I don't see a patch here so no idea why it's already set to NR, and this should go into HEAD first and then backported to older branches later if there's interest.

Please see attached.

Also, I could find no evidence that the other patch is in 4.x so there's nothing to do there, unless I'm missing something. And composer install works fine.

If there are no problems, you can just use git am to merge it, which preserves metadata, and you don't need to add it yourself (or bother with the git commit command below).

joseph.olstad’s picture

3x patch , removes patch that is no longer needed in 3.6

joseph.olstad’s picture

Issue summary: View changes
joseph.olstad’s picture

Issue summary: View changes

  • sylus committed 17cc99d on 4.0.x authored by colan
    Issue #3213872 by joseph.olstad, colan: Contrib security advisory on...
sylus’s picture

Status: Needs review » Fixed

Thanks so much!

Committed and attributed, I will probably do a release this weekend :)

joseph.olstad’s picture

Version: 4.0.x-dev » 8.x-3.x-dev
Status: Fixed » Needs review

Hi @sylus, this was pushed for 4.0.x (Thanks!) however I checked the 8.x-3.x branch and the 3x patch wasn't pushed?

is there plans for 3x?

colan’s picture

Version: 8.x-3.x-dev » 4.0.x-dev

According to the project page, that branch is no longer supported. I'd recommend upgrading to 4.

colan’s picture

Version: 4.0.x-dev » 8.x-3.x-dev

Sorry, didn't mean to switch branches (but this'll probably be a Wontfix).

joseph.olstad’s picture

just wondering, I can do some composer dependency override and patch ignore tricks for 3x otherwise.

joseph.olstad’s picture

Status: Needs review » Fixed

actually, I see it in 3x now

it's probably just in github but not on d.o repo

joseph.olstad’s picture

Status: Fixed » Needs review

nvm, was looking at ctools_block
still needs review for 3x

  • sylus committed 5519689 on 8.x-3.x authored by colan
    Issue #3213872 by joseph.olstad, colan, sylus: Contrib security advisory...
sylus’s picture

Status: Needs review » Fixed

Pushed to the 8.x-3.x line as well :D

Thanks everyone!

colan’s picture

Committed and attributed, I will probably do a release this weekend :)

Thanks for that. Can we get an ETA for the 4.x release as this is a security issue? I asked in https://message.gccollab.ca/channel/drupal but never got a response.

If you're too busy, is there anything I can do to help? e.g. Act as a co-maintainer to cut a release, etc.?

(I don't like asking for things on d.o without volunteering.)

joseph.olstad’s picture

Yes I was just going to ask about that

wondering about a 4.0.5 tag?

joseph.olstad’s picture

@colan, yes thanks for offering to assist Sylus as a co-maintainer. just noticed that.
might be a good idea to share the responsibility

Perhaps @colan could be made responsible for security advisory updates, releasing and tagging?

colan’s picture

If the help would be appreciated (if not, that's fine), it would be helpful if someone could point out docs for non-d.o stuff (if that would even be necessary for this kind of thing). While I maintain many projects here, there seems to be a GitHub component on this project. (We normally do all of our CI/CD with GitLab CI so I'm not up-to-speed on whatever GitHub does these days.)

The d.o stuff would be no problem at all, but I don't know about the other stuff yet.

Aside: We've rolled our own patch for this as we need to do a site release today, and I haven't heard back on what's going on here. Applying the patch above doesn't actually work because these get applied after the other ones so it's non-trivial. We needed to get the real diff and apply that.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.