Problem/Motivation

'Add above' in edit paragraph library in modal is behind parent dialog because a z-index is calculated wrong.

Steps to reproduce

Add a node with paragraphs, add a library paragraph, edit library paragraph, use 'Add above' to add some paragraph - you will see 'Add above' dialog which is behind the parent edit library dialog.

CommentFileSizeAuthor
#2 add-above-paragraph-library-not-visible-3213737-2.patch917 bytespivica

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica commented
Status: Active » Needs review
StatusFileSize
new add-above-paragraph-library-not-visible-3213737-2.patch917 bytes

Here is a patch. The problem is that we are not stopping event propagation in paragraphs.add_above_button.js clickHandler method. As a consequence UI dialog.js modusedown method can be called before dialog creation (correct sequence) or after dialog creation (not correct sequence). Comment in the patch explains this in more details.

  • Berdir committed 2f11d67 on 8.x-1.x authored by pivica 
    Issue #3213737 by pivica: 'Add above' in edit paragraph library in modal...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thank you. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.