Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Similar to #3210632: Update dependencies for Drupal 9.2 we should update our JS dependencies for 9.2.0-alpha1.
Steps to reproduce
Proposed resolution
$ cp yarn.lock old.yarn.lock
$ yarn upgrade
$ yarn build
$ yarn spellcheck:make-drupal-dict
$ yarn-lock-diff -o old.yarn.lock -n yarn.lock
┌──────────────────────────────┬────────────────────────────┬─────────────────────┐
│ package name │ old version(s) │ new version(s) │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/core │ 7.14.0 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/generator │ 7.14.0 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/helper-create-class-… │ 7.14.0 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/helper-function-name │ 7.12.13 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/helper-module-transf… │ 7.14.0 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/parser │ 7.14.0 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/plugin-proposal-asyn… │ 7.13.15 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/plugin-proposal-dyna… │ 7.13.8 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/plugin-proposal-expo… │ 7.12.13 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/plugin-proposal-json… │ 7.13.8 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/plugin-proposal-logi… │ 7.13.8 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/plugin-proposal-null… │ 7.13.8 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/plugin-proposal-nume… │ 7.12.13 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/plugin-proposal-obje… │ 7.13.8 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/plugin-proposal-opti… │ 7.13.8 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/plugin-proposal-opti… │ 7.13.12 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/plugin-transform-blo… │ 7.13.16 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/plugin-transform-cla… │ 7.13.0 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/plugin-transform-mod… │ 7.14.0 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/plugin-transform-par… │ 7.13.0 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/preset-env │ 7.14.0 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/traverse │ 7.14.0 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @babel/types │ 7.14.0 │ 7.14.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @cspell/dict-fullstack │ 1.0.37 │ 1.0.38 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @cspell/dict-software-terms │ 1.0.28 │ 1.0.29 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @eslint/eslintrc │ 0.4.0 │ 0.4.1 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ @types/node │ 15.0.1 │ 15.3.0 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ ajv │ 8.2.0 │ 8.4.0 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ caniuse-db │ 1.0.30001219 │ 1.0.30001226 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ caniuse-lite │ 1.0.30001221 │ 1.0.30001228 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ contains-path │ 0.1.0 │ 1.0.0 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ core-js-compat │ 3.11.1 │ 3.12.1 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ core-js-pure │ 3.11.1 │ 3.12.1 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ damerau-levenshtein │ 1.0.6 │ 1.0.7 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ debug │ [...], 4.3.1 │ [..., 4.3.1], 3.2.7 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ doctrine │ [..., 3.0.0], 2.1.0, 1.5.0 │ [...], 3.0.0, 2.1.0 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ dotenv │ 8.2.0 │ 8.6.0 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ electron-to-chromium │ 1.3.725 │ 1.3.728 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ eslint-module-utils │ 2.6.0 │ 2.6.1 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ eslint-plugin-import │ 2.22.1 │ 2.23.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ eslint-visitor-keys │ 2.0.0 │ 2.1.0 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ eslint │ 7.25.0 │ 7.26.0 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ follow-redirects │ 1.14.0 │ 1.14.1 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ glob │ 7.1.6 │ 7.1.7 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ is-bigint │ 1.0.1 │ 1.0.2 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ is-boolean-object │ 1.1.0 │ 1.1.1 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ is-core-module │ 2.3.0 │ 2.4.0 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ is-date-object │ 1.0.2 │ 1.0.4 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ is-number-object │ 1.0.4 │ 1.0.5 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ is-regex │ 1.1.2 │ 1.1.3 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ is-string │ 1.0.5 │ 1.0.6 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ is-symbol │ 1.0.3 │ 1.0.4 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ is2 │ 2.0.6 │ 2.0.7 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ load-json-file │ [..., 4.0.0], 2.0.0 │ [...], 4.0.0 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ lodash.flatten │ 4.4.0 │ - │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ nightwatch │ 1.6.3 │ 1.6.4 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ node-releases │ 1.1.71 │ 1.1.72 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ normalize-path │ [...], 3.0.0 │ [..., 3.0.0], 2.1.1 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ object-inspect │ 1.10.2 │ 1.10.3 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ parse-json │ [..., 5.2.0], 4.0.0, 2.2.0 │ [...], 5.2.0, 4.0.0 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ path-type │ [..., 4.0.0], 3.0.0, 2.0.0 │ [...], 4.0.0, 3.0.0 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ postcss-selector-parser │ 6.0.5 │ 6.0.6 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ prettier │ 2.2.1 │ 2.3.0 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ read-pkg-up │ [..., 7.0.1], 3.0.0, 2.0.0 │ [...], 7.0.1, 3.0.0 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ read-pkg │ [..., 5.2.0], 3.0.0, 2.0.0 │ [...], 5.2.0, 3.0.0 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ spdx-license-ids │ 3.0.7 │ 3.0.8 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ table │ 6.6.0 │ 6.7.1 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ unist-util-stringify-positi… │ [...] │ [..., 3.0.0] │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ vfile-message │ [...] │ [..., 3.0.1] │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ path-starts-with │ - │ 1.0.0 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ pkg-up │ - │ 2.0.0 │
├──────────────────────────────┼────────────────────────────┼─────────────────────┤
│ remove-trailing-separator │ - │ 1.1.0 │
└──────────────────────────────┴────────────────────────────┴─────────────────────┘
Note: A rebuild of the dictionaries seems necessary since there were changes in @cspell/dict-fullstack and @cspell/dict-software-terms.
But after merging the current HEAD into this MR and running yarn spellcheck:make-drupal-dict on an actual clean checkout of 9.3.x: No new words added.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|
Issue fork drupal-3210633
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
longwaveComment #3
longwavecspell dictionary needs regenerating as the source dictionaries have changed.
Comment #4
SpokjeFYI:
Regenerating the Drupal dictionary
Run:
Source: IS of #2972224: Add .cspell.json to automate spellchecking in Drupal core
(Currently on
8.9.xand no yarn installed, so can't do it myself without some hoop-jumping)Comment #5
longwaveRegenerated with a clean checkout and
yarn spellcheck:make-drupal-dictComment #8
bnjmnmThis needed a reroll. The diff is significantly smaller than the prior one, so either I missed something or some of these dependencies have been updated since the prior patch.
The MR is 9.3, the patch is 9.2. The dependencies changed are identical. There is a small difference between the two in dictionary.txt.
Comment #9
longwaveA lot of dependencies were already updated in #3211810: [security] Update Nightwatch and locked dev dependencies to address security issues
The only place these words and many others appear is in yarn.lock, which should be ignored by .cspell.json. I think my steps to reproduce don't take the old.yarn.lock file into account here.
Comment #10
bnjmnmThanks @longwave! #9
Comment #12
longwaveStill wonder where these (and other) new words are coming from, I don't have these in a clean checkout of core.
Comment #13
longwaveHmm actually I wonder if we should just leave the dictionary update to #3212547: cspell Dictionaries changed, checking all files
Comment #14
Spokje@longwave Indeed theyarn run spellcheck:make-drupal-dictsuggested by @catch in #3212547-18: cspell Dictionaries changed, checking all files gives a different (read: better) dictionary than a stand-aloneyarn spellcheck:make-drupal-dict, at least on my install.Something to remember/document somewhere, although not quite sure where...
Nevermind, shouldn't be doing 2 things at the same time...
Comment #15
bnjmnmWithout updating dictionary.txt, the 9.3 and 9.2 diffs are the same, so the MR I just pushed can be used for both.
Comment #16
Spokje#3212547: cspell Dictionaries changed, checking all files has been committed, so the MR is now the canonical Source of Truth for both
9.2.xand9.3.x.Comment #17
SpokjeDid another round of updating:
Note: A rebuild of the dictionaries seems necessary since there were changes in
@cspell/dict-fullstackand@cspell/dict-software-terms.However, the same as @Longwave experienced, I can't get
yarn.lockto be ignored (even though it's explicitly excluded in.cspell.jon.Will look into this later.
Comment #18
SpokjeLooking a bit more at my local Drupal install, it turned out there were some left-over files in there that shouldn't be (thank you,
git status --ignored.So after merging the current HEAD into this MR an running
yarn spellcheck:make-drupal-dicton an actual clean checkout of9.3.x: No new words added.So the MR as-is is ready for review.
Comment #19
SpokjeComment #20
SpokjeMR needed re-roll, took the opportunity to get the even more updated js depencies:
As you probably immediately noticed, in comparison to the previous version of the MR
@types/nodehas gone from15.0.1to15.0.3instead of15.0.2.Since the
cspelllibraries haven't changed since the last version of the MR, where we rebuild them and found no new words added, I didn't rebuild them this time.Comment #21
SpokjeSince this issue is a moving target and to prevent the comments to become a (very) long list of
yarn-lock-diffoutput per update, I put the output ofyarn-lock-diffin the IS, so it can be kept updated in there.Comment #22
SpokjeComment #23
SpokjeNew re-roll, new JS dependencies updated, updated the
yarn-lock-diffin the IS.Comment #24
zrpnrI ran the steps in the IS from 9.3.x HEAD, got the exact same yarn.lock file that is in the MR.
My yarn-lock-diff turned out identical to the one in the IS as well.
Ran
yarn run spellcheck:coreand didn't see any unknown words.If I run
yarn buildit hangs indefinitely in the css step, however I can run each of the commands (build:css, build:js, build:jqueryui) separately, and I get the same result on 9.3.x as I do on this MR so maybe it's something on my system.This seems like an uncontroversial change, most of the packages are just a minor release update.
Not sure what else we'd need to check here, I think this is good!
Comment #25
SpokjeSince the review by @zrpnr in #24 there were more updates all over the board.
Pulled in the latest ones, updated the IS with the output of
yarn-lock-diff.Not really sure if it's necessary, but putting this back to NR since there are changes done after the RTBC.
Comment #26
longwaveJavaScript dependencies never stop moving, I think we should just leave this at RTBC now, otherwise we will never get this in.
Comment #29
catchCommitted/pushed to 9.3.x and cherry-picked to 9.2.x, thanks!
Comment #30
drumm(Correcting cross-post.)