Problem/Motivation

Make cost types selectable on Cost List Blocks not on block setting page.

CommentFileSizeAuthor
#5 3209446-5.patch32.24 KBmasami
#3 3209446.patch31.53 KBmasami

Issue fork cloud-3209446

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Masami created an issue. See original summary.

Masami opened merge request !212

masami’s picture

masami commented
Status: Active » Needs review
StatusFileSize
new 3209446.patch31.53 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@masami

Thank you for the refactoring. I posted my comment. Please check the ones. Thanks

masami’s picture

masami commented
Status: Needs work » Needs review
StatusFileSize
new 3209446-5.patch32.24 KB

  • yas committed 3f634b6 on 3.x authored by Masami 
    Issue #3209446 by Masami, yas: Make cost types selectable on Cost List...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@masami

Thank you for the update. I tested the patch and it looks good. I'll merge the patch to 3.x and close this issue as Fixed.

yas closed merge request !212

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.