Drupal 9 readiness:

Need to correct following errors:

------ ----------------------------------------------------
Line src/Access/LikeItCsrfTokenGenerator.php
------ ----------------------------------------------------
92 Call to deprecated method hashEquals() of class
Drupal\Component\Utility\Crypt:
in drupal:8.8.0 and is removed from drupal:9.0.0.
Use PHP's built-in hash_equals() function instead.
------ ----------------------------------------------------

------ ----------------------------------------------------------------------
Line src/Entity/LikeIt.php
------ ----------------------------------------------------------------------
134 Return type of method Drupal\likeit\Entity\LikeIt::getTargetEntity()
has typehint with deprecated class Drupal\Core\Entity\Entity:
in drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\Entity\EntityBase instead.
------ ----------------------------------------------------------------------

------ ----------------------------------------------------------------------
Line src/Entity/LikeItInterface.php
------ ----------------------------------------------------------------------
77 Return type of method
Drupal\likeit\Entity\LikeItInterface::getTargetEntity() has typehint
with deprecated class Drupal\Core\Entity\Entity:
in drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\Entity\EntityBase instead.
------ ----------------------------------------------------------------------

------ ------------------------------------------------------------------
Line src/Event/LikeItEvent.php
------ ------------------------------------------------------------------
11 Class Drupal\likeit\Event\LikeItEvent extends deprecated class
Symfony\Component\EventDispatcher\Event:
since Symfony 4.3, use "Symfony\Contracts\EventDispatcher\Event"
instead
------ ------------------------------------------------------------------

[ERROR] Found 4 errors

CommentFileSizeAuthor
#5 reroll_diff-4_5.txt943 bytesshobhit_juyal
#5 likeit-3206919-5.patch1.64 KBshobhit_juyal
#4 likeit-3206919-4.patch1.63 KBdripa
#3 likeit-3206919-3.patch1.31 KBdripa
#2 3206919-2.patch2.12 KBsnehi

Issue fork likeit-3206919

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

snehi created an issue. See original summary.

snehi’s picture

snehi commented
Status: Active » Needs review
StatusFileSize
new 3206919-2.patch2.12 KB

Putting first patch for the same.

dripa’s picture

dripa commented
StatusFileSize
new likeit-3206919-3.patch1.31 KB

The files in patch #2 are referencing to the site doc root and therefore not applying.
Here's a new patch based on #2 with references to the module doc root.

dripa’s picture

dripa commented
StatusFileSize
new likeit-3206919-4.patch1.63 KB

Forgot the version requirement check, uploaded new patch

shobhit_juyal’s picture

shobhit_juyal commented
StatusFileSize
new likeit-3206919-5.patch1.64 KB
new reroll_diff-4_5.txt943 bytes

The last patch wont applied therefore, Uploading new patch as #5.

shobhit_juyal opened merge request !1

andrew_tspkh closed merge request !1

andrew_tspkh’s picture

andrew_tspkh
Primary language Ukrainian
commented
Status: Needs review » Fixed

Committed to 2.0.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.