Problem/Motivation

PHP 8 test results (e.g. https://www.drupal.org/pift-ci-job/2017309 ) include:

exception: [Deprecated function] Line 147 of modules/openid/openid.inc:
Function libxml_disable_entity_loader() is deprecated

exception: [Deprecated function] Line 196 of modules/openid/openid.inc:
Function libxml_disable_entity_loader() is deprecated

Steps to reproduce

Proposed resolution

Fix these deprecated function messages.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3206438

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mcdruid created an issue. See original summary.

mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid at Acquia commented
Parent issue: » #3145797: [META] Make Drupal 7 core compatible with PHP 8.0
Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented
Issue tags: -PHP 8 +PHP 8.0
Ayesh’s picture

Ayesh CreditAttribution: Ayesh commented
Assigned: Unassigned » Ayesh

Pretty straight forward. Patch coming through.

Ayesh opened merge request !474

Ayesh’s picture

Ayesh CreditAttribution: Ayesh commented
Assigned: Ayesh » Unassigned
Status: Active » Needs review
mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid at Acquia commented

Thanks @Ayesh - I think we need to use the other PHP 8 testing option though (without the composer args/options).

Ayesh’s picture

Ayesh CreditAttribution: Ayesh commented

You are right, the one without composer options did the trick.
Patch fails on PHP 8.0, but they are related to the other failures linked in the parent issue.

Taran2L’s picture

Taran2L
Primary language Ukrainian
Location Lviv
CreditAttribution: Taran2L at Lemberg Solutions commented
Status: Needs review » Reviewed & tested by the community

Looks good to me!

mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid at Acquia commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Pending Drupal 7 commit

LGTM too, thanks!

mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid at Acquia commented
Status: Needs review » Reviewed & tested by the community

Ooops. I think I need a browser addon that says "did you really mean to change the Status?" :)

mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid at Acquia commented

Comparing the exceptions from the noop patch in the parent to the latest PHP 8 test for the MR:

$ curl -s https://www.drupal.org/pift-ci-job/2017309 | grep -o 'exception: .* Line [0-9]* of .*:' | perl -pe 's#<.*?>##g' | sort | uniq -c | sort -rn | diff - <(curl -s https://www.drupal.org/pift-ci-job/2017342 | grep -o 'exception: .* Line [0-9]* of .*:' | perl -pe 's#<.*?>##g' | sort | uniq -c | sort -rn)
1,2d0
<     100 exception: [Deprecated function] Line 147 of modules/openid/openid.inc:
<      98 exception: [Deprecated function] Line 196 of modules/openid/openid.inc:

That's exactly what we want to see.

  • mcdruid committed b6867ff on 7.x 
    Issue #3206438 by Ayesh: [PHP 8] deprecated functions in OpenID
mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid at Acquia commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Pending Drupal 7 commit

Thank you... nearly there!

mcdruid closed merge request !474

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.