FILE: /home/sahana/Sites/contribution/web/modules/contrib/group_taxonomy/group_taxonomy.services.yml
----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------


FILE: /home/sahana/Sites/contribution/web/modules/contrib/group_taxonomy/group_taxonomy.module
--------------------------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 11 LINES
--------------------------------------------------------------------------------------------------------------------
  3 | ERROR | [ ] Missing short description in doc comment
 19 | ERROR | [ ] Missing parameter comment
 29 | ERROR | [ ] Missing parameter comment
 39 | ERROR | [x] Use "elseif" in place of "else if"
 53 | ERROR | [x] Data types in @param tags need to be fully namespaced
 54 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
 56 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
 57 | ERROR | [ ] Missing parameter type
 58 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
 64 | ERROR | [ ] Expected type hint "AccountInterface"; found "\Drupal\Core\Session\AccountInterface" for $account
 64 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
 74 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------


FILE: /home/sahana/Sites/contribution/web/modules/contrib/group_taxonomy/group_taxonomy.links.task.yml
------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
 5 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------

Time: 131ms; Memory: 10MB
CommentFileSizeAuthor
#7 03.png13.51 KBroman-yrv
#6 3204465-6.patch3.66 KBsahana _n
#4 3204465-4.patch3.73 KBsahana _n
#3 02.png35 KBroman-yrv
#3 01.png88.5 KBroman-yrv
#2 phpcs-error.patch3.53 KBsahana _n

Comments

Sahana _N created an issue. See original summary.

sahana _n’s picture

sahana _n commented
Status: Active » Needs review
StatusFileSize
new phpcs-error.patch3.53 KB

Please review the patch.

roman-yrv’s picture

roman-yrv commented
StatusFileSize
new 01.png88.5 KB
new 02.png35 KB

I tested the code of the module with PHP Code Sniffer before patching (see a screenshot)

Code Sniffer before patching

And after patching (see a screenshot)

Code Sniffer after patching

sahana _n’s picture

sahana _n commented
StatusFileSize
new 3204465-4.patch3.73 KB

Please review the patch I updated the patch.

roman-yrv’s picture

roman-yrv commented

I tested the new patch.
The same problem.
But if you remove the block from the code

 /*
  @var $entity_types \Drupal\Core\Entity\EntityTypeInterface[]
   */

the code sniffer test will be pass without any problem.

sahana _n’s picture

sahana _n commented
StatusFileSize
new 3204465-6.patch3.66 KB

Please review the patch once again.

roman-yrv’s picture

roman-yrv commented
StatusFileSize
new 03.png13.51 KB

Yes, it passes now successfully without any messages.

PHP Code Sniffer

carolpettirossi’s picture

carolpettirossi commented

Thanks for reporting and fixing the coding standard issues. Patch has been applied and committed.

carolpettirossi’s picture

carolpettirossi commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.