Problem/Motivation

I enabled the module, and also checked the box in content type image field settings. But the rotate icon is not displayed.

Steps to reproduce

  1. Install `2.1.0` module
  2. Check the "Add the rotate icon" to the image field of the Article page
  3. Create a new article and upload an image
  4. Notice that the rotate icon is missing

Issue fork simple_image_rotate-3203735

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tjtj created an issue. See original summary.

tjtj’s picture

tjtj commented

The version I got before this module was "official" works after patching the version requirement. But alas, it throws a php error.

davidiio’s picture

davidiio commented

EDIT: Sorry, in my case the use Drupal\Core\Config\Entity\ThirdPartySettingsInterface; instruction was missing (not sure why exactly) and so the condition I mentioned earlier coudn't work.

Same here with drupal 8.9.13 and simple_image_rotate 2.1.0 using Media.
I think the problem appeared before I upgraded to 2.1.0 when I applied the patch from this issue:
https://www.drupal.org/project/simple_image_rotate/issues/3126067

Is it possible that this condition always verifies and so field is always skipped?

if (!($field instanceof ThirdPartySettingsInterface)) {
         continue;
       }
tjtj’s picture

tjtj commented

That fixed this. Please put the patch into the release version

steveoriol made their first commit to this issue’s fork.

steveoriol opened merge request !1

steveoriol closed merge request !1

genfoch01’s picture

genfoch01 commented

Is there an eta for the fix being rolled out? I am on drupal 8.9.14 and simple image rotate 2.1.0 and do not see the rotate icon

EDIT : I've never done this before but the change looked small enough for me to apply manually which seemed to work.
this is a really helpful module.
thanks for your time.

hyside’s picture

hyside commented

@steveoriol -

Is looks like this change wasn't actually merged into 2.1.X :

Closed by steveoriol 2 weeks ago (Apr 29, 2021 2:28pm GMT+0200)
The changes were not merged into 2.1.x

If there is a reason this wasn't merged, could we reopen this issue until an acceptable solution is found? I can continue to maintain a manual patch, but rolling in a solution sure makes composer-based sites easier to keep up-to-date.

Thank you!

nathan tsai’s picture

nathan tsai commented
Title: Image rotate icon does not appear in 9.1.4 » Module Broken in 2.1.0
Priority: Major » Critical
Issue summary: View changes
andreasderijcke’s picture

andreasderijcke
Location Antwerpen / Gent
commented

Last commit on 2.1.x does include the fix.
New release is recommended.

david jeyachandran’s picture

david jeyachandran commented

Seconding @andreasderijcke. Could we have a new release please. Seems like a simple fix of adding a single line...
use Drupal\Core\Config\Entity\ThirdPartySettingsInterface;

markus_petrux’s picture

markus_petrux commented

Just to confirm the patch is included in 2.1.0-dev. and works. Thank you!

markus_petrux’s picture

markus_petrux commented
Status: Active » Reviewed & tested by the community
nathan tsai’s picture

nathan tsai commented

Any updates on a new release?

nathan tsai’s picture

nathan tsai commented
Title: Module Broken in 2.1.0 » Module Missing `Drupal\Core\Config\Entity\ThirdPartySettingsInterface`
afagioli’s picture

afagioli
Location Rome
commented

Thanks!

  • afagioli committed 94e2400 on 2.1.x 
    fix #3186522, #3203735, #3223056, #3255089
afagioli’s picture

afagioli
Location Rome
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

nathan tsai’s picture

nathan tsai commented

I just came across this issue again today when I tried installing the default version of the module.

The current recommended release does not work at all due to this patch not being applied.

I suggest creating a new (full) release of the module using the alpha (2.1.1-alpha1)

(Especially, since there has also been 1,044 installs so far, as of Dec 9, 2023).

afagioli’s picture

afagioli
Location Rome
commented
Status: Closed (fixed) » Needs work
afagioli’s picture

afagioli
Location Rome
commented
Status: Needs work » Fixed

Find this fix with https://www.drupal.org/project/simple_image_rotate/releases/2.3.0-alpha1

Thanks for contributing

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.