New fields creation doesn't work [#3203629]

Problem/Motivation

The latest hook update (shorthand_update_8002()) introduced by this commit creates new fields but it always fails with this error:

Drupal\Core\Entity\EntityStorageException with message 'Unsupported entity type '

Steps to reproduce

Install shorthand version 2.0
Update it to version 2.1
Run update.php (or drush updb)

Proposed resolution

Instead of using Drupal::entityDefinitionUpdateManager()->updateFieldableEntityType() to update the whole entity type, let's use Drupal::entityDefinitionUpdateManager()->installFieldStorageDefinition() to install each new field individually.

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

Comment	File	Size	Author
#2	new-fields-creation-doesnt-work-3203629-2.patch	3.56 KB	villette

Issue fork shorthand-3203629

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3203629-new-fields-creation changes, plain diff MR !1
Check out this branch for the first time

Check out existing branch, if you already have it locally