Problem/Motivation

  • When deleting a Launch Template, it is not deleted from AWS. This happens when a user uses the Delete form and Multi-select Delete form to delete an AWS Cloud Launch Template
  • Pay attention in making this change so that when a Cloud Service Provider is deleted, the Launch templates on AWS are not deleted.
CommentFileSizeAuthor
#10 3202402-10.patch12.13 KByas
#9 3202402-9.patch12.16 KByas
#6 3202402-6.patch7.9 KByas
#5 3202402-5.patch7.85 KByas
#3 3202402-3.patch2.65 KByas

Issue fork cloud-3202402

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yas created an issue. See original summary.

yas opened merge request !173

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Active » Needs review
StatusFileSize
new 3202402-3.patch2.65 KB
baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Needs work
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3202402-5.patch7.85 KB

@baldwinlouie

Thank you for your review. I like your suggested approach, so I re-created the patch based on your patch at #3201071.

The DrupalCI test should fail but could you please review it?

* Note that I refactored your code.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3202402-6.patch7.9 KB

Fixing the coding standard violations.

baldwinlouie’s picture

baldwinlouie commented

@yas, Thank you for updating the patch. The code change looks good to me. Since the patch fails because of dependencies from #3201071, how are we going to commit changes?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie

Thank you for your review. Can I include the event subscribers portion on your patch since this patch fixes a bug? If it is ok, I'll re-create the patch on this issue.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3202402-9.patch12.16 KB

@baldwinlouie

Refactored to merge the Event Subscribers portion of your patch at #3201071. Could you please review it?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3202402-10.patch12.13 KB

Fixed the coding standard violations and a bug.

baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Reviewed & tested by the community

@yas, thank you for providing the patch. It looks good to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie

Thank you for your review. I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed b0b39d3 on 3.x 
    Issue #3202402 by yas, baldwinlouie: Delete AWS Launch Templates when...

yas closed merge request !173

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.