Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
- When deleting a Launch Template, it is not deleted from AWS. This happens when a user uses the Delete form and Multi-select Delete form to delete an AWS Cloud Launch Template
- Pay attention in making this change so that when a Cloud Service Provider is deleted, the Launch templates on AWS are not deleted.
Comment | File | Size | Author |
---|---|---|---|
#10 | 3202402-10.patch | 12.13 KB | yas |
Issue fork cloud-3202402
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3202402-delete-aws-launch changes, plain diff MR !173
Comments
Comment #3
yasComment #4
baldwinlouie CreditAttribution: baldwinlouie commentedComment #5
yas@baldwinlouie
Thank you for your review. I like your suggested approach, so I re-created the patch based on your patch at #3201071.
The DrupalCI test should fail but could you please review it?
* Note that I refactored your code.
Comment #6
yasFixing the coding standard violations.
Comment #7
baldwinlouie CreditAttribution: baldwinlouie commented@yas, Thank you for updating the patch. The code change looks good to me. Since the patch fails because of dependencies from #3201071, how are we going to commit changes?
Comment #8
yas@baldwinlouie
Thank you for your review. Can I include the event subscribers portion on your patch since this patch fixes a bug? If it is ok, I'll re-create the patch on this issue.
Comment #9
yas@baldwinlouie
Refactored to merge the Event Subscribers portion of your patch at #3201071. Could you please review it?
Comment #10
yasFixed the coding standard violations and a bug.
Comment #11
baldwinlouie CreditAttribution: baldwinlouie commented@yas, thank you for providing the patch. It looks good to me.
Comment #12
yas@baldwinlouie
Thank you for your review. I'll merge the patch to
3.x
and close this issue asFixed
.Comment #15
yas