Problem/Motivation

4.dev works fine
5.dev doesn't

Steps to reproduce

Create a Glisseo Subtheme, install together with Glisseo on a clean D9 site.
Set Bartik to default theme. Cheeseburger Menu 5 dev works.
Set the Glisseo Subtheme to default. Cheeseburger Menu doesn't work.
Uninstall Cheeseburger 5.dev and install 4.dev. Configure the block. It works.

Glisseo is a modern theme that uses CSS variables and CSS grids, ITCSS architecture for style structure and BEM methodology for template class naming. I use it all the time.

Is the problem is related to the theme or to Cheeseburger Menu? Since version 4 works with Glisseo my question is what is different other than the UX?

I attach a short demo film.

If you would want to have a look I'll be happy to upload a zipped test site.

Thanks

CommentFileSizeAuthor
cheeseburger_glisseo.mp41.78 MBhs@henrikstrindberg.se

Comments

hstrindb created an issue. See original summary.

hs@henrikstrindberg.se’s picture

hs@henrikstrindberg.se commented

Could it be a problem with the module Twig Tweak? This is a dependency for Glisseo.

Thanks

holo96’s picture

holo96 commented

It seems it has something to do with css variables, I'll investigate further why exactly this happens

  • DavorHorvacki committed 7215b39 on 5.0.x 
    Issue #3201168 by hstrindb, DavorHorvacki: Doesn't work with Glisseo...
holo96’s picture

holo96 commented
Status: Active » Needs review

Glisseo theme is not defining block ids as other drupal themes.. But I've added exception for glisseo

holo96’s picture

holo96 commented
Status: Needs review » Needs work

Also need to add trigger class

hs@henrikstrindberg.se’s picture

hs@henrikstrindberg.se commented

Trying Stark 9.1.5 as the default theme and it's the same problem.
(And yes, I just tested the last dev version and it still doesn't work.)

Thanks for looking into this!

  • DavorHorvacki committed 44713ce on 5.0.x 
    Issue #3201168 by hstrindb, DavorHorvacki: Doesn't work with Glisseo...
holo96’s picture

holo96 commented
Status: Needs work » Needs review

Works for me now... Had to update which block should be triggered on glisseo

holo96’s picture

holo96 commented

hstrindb
Can you verify this task? I am preparing beta3

hs@henrikstrindberg.se’s picture

hs@henrikstrindberg.se commented

Hi!
- Cheeseburger Menu now works with Stable
- It's fine with Glisseo base theme
- Still doesn't work woth a Glisseo sub theme.

I have create an issue for Glisseo asking about this.

hs@henrikstrindberg.se’s picture

hs@henrikstrindberg.se commented

Niklan also explained the same problem that you mention in #5 and he also gave a block--cheeseburger-menu.html.twig file to make Cheeseburger Menu work with Glisseo sub themes.
https://www.drupal.org/project/glisseo/issues/3207754#comment-14054380

I’m very pleased to be able to use Cheeseburger Menu together with the Glisseo theme!

hs@henrikstrindberg.se’s picture

hs@henrikstrindberg.se commented
Status: Needs review » Reviewed & tested by the community
holo96’s picture

holo96 commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.