Some configuration items mainly in Smart Date Recurring module have no configuration schema.

CommentFileSizeAuthor
#7 smart_date-configuration_schema-3200580-7.patch2.45 KBchi
#5 smart_date-configuration_schema-3200580-5.patch1.89 KBchi
#2 smart_date-configuration_schema-3200580-2.patch1.89 KBchi

Comments

Chi created an issue. See original summary.

chi’s picture

chi commented
Status: Active » Needs review
StatusFileSize
new smart_date-configuration_schema-3200580-2.patch1.89 KB
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Reviewed & tested by the community

Fixes the issue.

chi’s picture

chi commented
Status: Reviewed & tested by the community » Needs work

The patch #2 breaks field widget because the configuration schema is changing the underlying config values.

     third_party_settings:
         allowed_recur_freq_values:
-          DAILY: DAILY
-          WEEKLY: WEEKLY
-          MONTHLY: MONTHLY
-          YEARLY: YEARLY
-          MINUTELY: 0
-          HOURLY: 0
+          DAILY: true
+          WEEKLY: true
+          MONTHLY: true
+          YEARLY: true
+          MINUTELY: false
+          HOURLY: false
chi’s picture

chi commented
StatusFileSize
new smart_date-configuration_schema-3200580-5.patch1.89 KB
chi’s picture

chi commented
Status: Needs work » Needs review

The schema in patch #5 produces less destructive type casting.

allowed_recur_freq_values:
-          DAILY: DAILY
-          WEEKLY: WEEKLY
-          MONTHLY: MONTHLY
-          YEARLY: YEARLY
-          MINUTELY: 0
-          HOURLY: 0
+          DAILY: DAILY
+          WEEKLY: WEEKLY
+          MONTHLY: MONTHLY
+          YEARLY: YEARLY
+          MINUTELY: '0'
+          HOURLY: '0'

However, I think eventually it is better to update Widget implementation and use schema from patch #2 because frequency values by nature are booleans.

chi’s picture

chi commented
StatusFileSize
new smart_date-configuration_schema-3200580-7.patch2.45 KB

Added missing schema for field widget with timezone.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Reviewed & tested by the community

Sorry I missed that earlier in my over eager RTBC. This looks better.

kris77’s picture

kris77 commented

#7 works for me.

Thanks @Chi

mandclu’s picture

mandclu commented
Status: Reviewed & tested by the community » Fixed

Merged this into a new 3.2.x branch, hope to get a new release out soon. Thanks for your work on this!

  • fc3df93 committed on 3.2.x 
    Merge branch '3.2.x' into features/html5-time-wrapper

* 3.2.x:
  Issue...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.