Problem/Motivation

$this→assertTrue(assert($condition), 'messsage'); should not contain the assert() — otherwise it masks the actual test failure.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 3198135-5.patch1.29 KBwim leers
#2 3198135-2.patch1.29 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 3198135-2.patch1.29 KB
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Passes tests. This is IMHO fine to self-RTBC.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Status: Reviewed & tested by the community » Needs work

It would be better to use assertInstanceOf.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new 3198135-5.patch1.29 KB

Oh, you're totally right! I just optimized for minimal change. But +1 to getting it right! 🤓Done!

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

  • huzooka committed b439a5d on 8.x-1.x authored by Wim Leers 
    Issue #3198135 by Wim Leers: Fix minor bug in \Drupal\Tests\...
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Version: 8.x-1.0-alpha8 » 8.x-1.x-dev
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Component: Code » Test

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.