Problem/Motivation

Create Resource Stores with same timestamp for Projects at one cron job.

CommentFileSizeAuthor
#20 3197653-19.patch899 bytesyas
#12 3197653-12.patch11.25 KBmasami
#10 3197653-10.patch11.21 KBmasami
#8 3197653-8.patch16.27 KBmasami
#7 3197653-7.patch16.27 KBmasami
#5 3197653-5.patch14.45 KBmasami
#3 3197653.patch12.23 KBmasami

Issue fork cloud-3197653

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Masami created an issue. See original summary.

Masami opened merge request !144

masami’s picture

masami commented
Status: Active » Needs review
StatusFileSize
new 3197653.patch12.23 KB

Status: Needs review » Needs work

The last submitted patch, 3: 3197653.patch, failed testing. View results

masami’s picture

masami commented
Status: Needs work » Needs review
StatusFileSize
new 3197653-5.patch14.45 KB

Status: Needs review » Needs work

The last submitted patch, 5: 3197653-5.patch, failed testing. View results

masami’s picture

masami commented
Status: Needs work » Needs review
StatusFileSize
new 3197653-7.patch16.27 KB
masami’s picture

masami commented
StatusFileSize
new 3197653-8.patch16.27 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@masami

Thank you for the refactoring. Please see my above comments. Thanks

masami’s picture

masami commented
Status: Needs work » Needs review
StatusFileSize
new 3197653-10.patch11.21 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@masami

Thank you for the update. Please see my above comments. Thanks

masami’s picture

masami commented
Status: Needs work » Needs review
StatusFileSize
new 3197653-12.patch11.25 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@masami

Thank you for the update. It looks good to me now.

@masatotakada

What do you think?

MasatoTakada’s picture

MasatoTakada commented

@yas

It looks good to me.
Thanks.

Masato

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@masatotakada

Thank you for your review. I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed bd51313 on 3.x authored by Masami 
    Issue #3197653 by Masami, yas, MasatoTakada: Create Resource Stores with...

yas closed merge request !144

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

yas opened merge request !146

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs review
StatusFileSize
new 3197653-19.patch899 bytes

@masami

Fixing the coding violations. Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@all The tests have been passed successfully, so I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed f026653 on 3.x 
    Issue #3197653 by yas: Fix the coding standard violations
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

yas closed merge request !146

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.