Problem/Motivation

Vue has a new slot syntax since 2.6 - the usual web component syntax is deprecated and unsupported in Vue3.
Let's add support for the new syntax, but allow selecting the web component syntax as well

New syntax: https://vuejs.org/v2/guide/components-slots.html

Issue fork custom_elements-3196994

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fago created an issue. See original summary.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Active » Needs review

I've implemented this by following https://vuejs.org/v2/guide/components-slots.html#Named-Slots-Shorthand
For that - I made the markup style configurable. The previous web-component style stays default, the new one is configurable. TODO is documentation.

The config has no UI yet, but that could be added later on anyway.

fago opened merge request !6

  • fago committed fdcc3d9 on 3196994-support-new-vue 
    Issue #3196994: Add update hook and overhaul documentation.
fago’s picture

fago
Primary language German
Location Vienna
commented
Issue tags: +Needs tests

We need to add a test case covering the new vue-3 style syntax.

  • mostepaniukvm committed d78c79b on 3196994-support-new-vue 
    Issue #3196994: Test coverage for new vue-3 style slot syntax.

mostepaniukvm made their first commit to this issue’s fork.

mostepaniukvm’s picture

mostepaniukvm
he/him
commented

@fago your changes look good
added test coverage for new vue3 slot syntax, needs review

  • fago committed 8523821 on 8.x-2.x 
    Issue #3196994: Add support for new vue-3 style slot syntax and make the...
  • mostepaniukvm committed d78c79b on 8.x-2.x
    Issue #3196994: Test coverage for new vue-3 style slot syntax.
  • fago committed fdcc3d9 on 8.x-2.x
    Issue #3196994: Add update hook and overhaul documentation.
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed
Issue tags: -Needs tests

thx, test looks great and works fine! Thus, this is ready to go - merged!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.