Problem/Motivation

To ease the access to the flood unblock form.

Issue fork flood_control-3195588

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 2.0.x Comparecompare
    • 1 hidden branch
  • 3195588-menu_link Comparechanges, plain diff MR !13
About issue forks

Comments

Grimreaper created an issue. See original summary.

Grimreaper opened merge request !13

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Active » Needs review
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue tags: +GlobalContributionWeekend2021
kgaut’s picture

kgaut commented
Status: Needs review » Reviewed & tested by the community

Working as expected :)

rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
commented
Issue tags: -GlobalContributionWeekend2021 +ContributionWeekend2021

Just doing a little tag tidying. Nice work everyone!!

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

We already have tab in the admin/people page that links to the Flood Unblock page. This was already the case when Flood Unblock was a separate module.

To help users find the unblock page and settings page, we added links to the page description. Not sure if that helps.

I am not sure if it is a good / bad practice to have both a menu link and a task tab for the same admin page. What do you think?

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Hello,

Thanks @rachel_norfolk!

Thanks @batigolix for the reply.

I think it is a best practice to have both. A menu link allows to avoid to have go on the intermediary page.

It is good to have documented the page on the project description, but that is for the admin or the devshop building the website and evaluating the module. On a daily basis usage and for the website administrators in general, people do not go on project pages to read the documentation.

(Also the existing menu link in links.menu.yml is on the "devel" menu, I think it would be better on the admin menu.)

Phil Wolstenholme’s picture

Phil Wolstenholme commented

+1 for including both

Phil Wolstenholme’s picture

Phil Wolstenholme commented

I've also updated the MR to use the admin rather than devel menu. It looks like the devel menu mention might have been a copy/paste error.

https://git.drupalcode.org/project/flood_control/-/merge_requests/13/dif...

  • batigolix committed 04e8511 on 2.0.x 
    Issue #3195588 by Grimreaper, Phil Wolstenholme: Add menu link in people...
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Postponed (maintainer needs more info) » Fixed

I committed this change. Thanks!

batigolix closed merge request !13

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.