Problem/Motivation

Add approval systems to process workflow status in AWS Cloud launch template (Test Cases)

CommentFileSizeAuthor
#12 3194877-12.diff16.32 KBsekinet
#9 3194877-8.diff16.9 KBsekinet
#7 3194877-7.diff16.9 KBsekinet
#5 3194877-5.diff17.64 KBsekinet
#3 3194877-3.diff13.87 KBsekinet

Issue fork cloud-3194877

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sekinet created an issue. See original summary.

sekinet opened merge request !124

sekinet’s picture

sekinet commented
StatusFileSize
new 3194877-3.diff13.87 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Active » Needs work

@sekinet

Thank you for adding the test cases. Please see my above comments. Thanks

sekinet’s picture

sekinet commented
StatusFileSize
new 3194877-5.diff17.64 KB
sekinet’s picture

sekinet commented
Status: Needs work » Needs review

@yas Thank you for your comments. Could you confirm that you have made the corrections?
Thanks.

sekinet’s picture

sekinet commented
StatusFileSize
new 3194877-7.diff16.9 KB

Status: Needs review » Needs work

The last submitted patch, 7: 3194877-7.diff, failed testing. View results

sekinet’s picture

sekinet commented
StatusFileSize
new 3194877-8.diff16.9 KB
sekinet’s picture

sekinet commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add approval systems to process workflow status in AWS Cloud launch template (8) (Test Cases) » Add approval systems to process workflow status in AWS Cloud launch template (Test Cases)
Status: Needs review » Needs work

@sekinet

Thank you for the update. I posted my comments. Thanks.

sekinet’s picture

sekinet commented
StatusFileSize
new 3194877-12.diff16.32 KB
sekinet’s picture

sekinet commented
Status: Needs work » Needs review

@yas Thank you for your comments. The patch has been corrected. Could you please check?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@sekinet

Thank you for the update. It looks pretty good. I'll merge the patch to code>3.x and close this issue as Fixed.

  • yas committed 03f001d on 3.x authored by sekinet 
    Issue #3194877 by sekinet, yas: Add approval systems to process workflow...

yas closed merge request !124

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.