As a follow-up a discussion https://www.drupal.org/project/at_theme/issues/3192788, I suggest that we move lazy builder class from at_theme to the at_tool and make it service. In that case we can use dependency injection.

Remaining tasks

  • make patch for at_tool module
  • test and commit the patch for at_tool module
  • make patch for at_theme, inculding changes of composer.json (dependency of latest at_tool version)
  • commit patch for at_theme
CommentFileSizeAuthor
#2 move-lazy-builders-to-at_tool-3194455-2.patch2.43 KBeugene bocharov

Comments

boch created an issue. See original summary.

eugene bocharov’s picture

eugene bocharov commented
Issue summary: View changes
StatusFileSize
new move-lazy-builders-to-at_tool-3194455-2.patch2.43 KB

  • mattbloomfield committed 7ecff86 on 1.0.x 
    Issue #3194455 by boch: Move LazyBuilders class from at_theme to at_tool...
mattbloomfield’s picture

mattbloomfield commented

This has been committed. Thanks for your work.

eugene bocharov’s picture

eugene bocharov commented
Issue summary: View changes
Status: Active » Fixed

Thank you @mattbloomfield for working at this project.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rossidrup’s picture

rossidrup commented

has this error has anything to do with it?

2021/05/27 07:43:39 [error] 2013#2013: *359 FastCGI sent in stderr: "PHP message: Uncaught PHP Exception InvalidArgumentException: "Class "at_tool.lazy_builders" does not exist." at /var/www/html/web/core/lib/Drupal/Core/DependencyInjection/ClassResolver.php line 24" while reading response header from upstream, client: 172.18.0.6, server: , request: "GET /sevanje HTTP/1.1", upstream: "fastcgi://unix:/run/php-fpm.sock:", host: "drupal8test.ddev.site", referrer: "https://drupal8test.ddev.site/"

rossidrup’s picture

rossidrup commented
Priority: Normal » Critical