Amp Optimizer Beta release Roadmap !!!

Hi, Thanks for working on the module. Is there a Roadmap for a beta or stable release? I am proposing a few ideas of my own. Once agreed upon we can also open dedicated Issues for it.

TBD

  1. Limit only for the Html renderable requests by using the render api instead of the events api
  2. Disable amp optimizer for logged in users as its not cached or crawled by searched engines.
  3. Tests
  4. Documentation
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

kneek created an issue. See original summary.

voleger’s picture

1. The possible way is to move the optimizing method call to the #post_render callback stack of html render element. But the problem is that is never performing the #post_render callbacks for html render elemement. So I decided to keep the approach (using event subscriber), but use best practice to limit the response cases which need to be optimized. See similar implementation in minifyhtml module https://git.drupalcode.org/project/minifyhtml/-/blob/8.x-1.x/src/EventSu...
2. This is doable by introducing an earlier check of the user status.
3. Tests will require the testing module which implements the controller with testing AMP response. Then we can cover some specific test cases of integration. The library which used by this module is well tested itself.

voleger’s picture

Title: Beta release roadmap. » Beta release roadmap

Current changes are enough to publish beta stability level release.

  • voleger committed aeebf63 on 1.0.x
    Issue #3194432 by voleger: Beta release roadmap
    
voleger’s picture

Title: Beta release roadmap » Stable release roadmap
Issue summary: View changes

Now the target is to release a stable release.

kneek’s picture

This works great now , thanks !