Closed (fixed)
Project:
Media entity slideshow
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
20 Jan 2021 at 08:38 UTC
Updated:
17 Feb 2021 at 12:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
chr.fritschComment #3
chr.fritschHere is the patch to review
Comment #4
chr.fritschOh god, damn it. Wrong project...
Comment #5
chr.fritschComment #6
volkerk commentedFunction should be called something more obvious like createThumbnail(), createCollage() or simply create().
Use Drupal/Component/Utility/Color class
What happens when this is called with an empty array? It seems like 'default' case will fail badly.
Comment #7
chr.fritschFixed the remarks.
Comment #8
volkerk commentedAdd moar padding (10).
Comment #9
kneek commentedLooks very nice !!! Thanks a lot for the quick response on the issue. Agree with #8 that it needs more padding
Comment #10
chr.fritschHere comes the test.
Comment #12
chr.fritschTry to make the tests more robust.
Comment #13
chr.fritschCode cleanup
Comment #14
chr.fritsch#13 is broken. Let's stay with #12
Comment #15
volkerk commented#12 seems fine
Comment #17
chr.fritsch