See https://www.drupal.org/pift-ci-job/1916161, I accidentaly included PHP 7.1 syntax in a recent issue.
We should either revert that or explicitly mark it as requiring PHP 7.1+ in .info.yml and composer.json, so it can't be installed on older versions. Can't fix the release out there, but can at least mark future ones correctly.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3188415-2.patch | 546 bytes | matroskeen |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
matroskeenThere is no need to revert, the fix is pretty easy
Upd: I'm sorry, I didn't notice Novice tag 🙄
Comment #3
wizonesolutionsI vote for committing this patch because Commerce (and thus Commerce Recurring) still supports PHP 7 and uses Token. That's obviously not your problem, but would be great if possible.
I will reproduce the issue locally and test this today and RTBC if all looks good.
Comment #5
wizonesolutionsWorks great. Opened it as a merge request as well now.
Comment #6
berdir> There is no need to revert, the fix is pretty easy
I meant revert in the conceptual way of reverting the change, not a git revert, so exactly what you did ;)
Fine with committing this, will just have to be careful to not break this, maybe set the default php version for tests to 7.0 for now.
Comment #7
wizonesolutionsThat's what Commerce Recurring does, so not a bad idea.
Comment #9
berdirCommitted