Problem/Motivation

The total count is not returned along with the view.

Proposed resolution

Add the count field to the meta section of the response, like in jsonapi_extras.

CommentFileSizeAuthor
#5 3187221-total_count-5.patch7.66 KBdeciphered
#4 3187221-total_count-4.patch6.23 KBdeciphered
#4 3187221-total_count-4-test_only.patch4.2 KBdeciphered
#2 3187221-2.patch2 KBblazey

Issue fork jsonapi_views-3187221

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

blazey created an issue. See original summary.

blazey’s picture

blazey commented
Assigned: blazey » Unassigned
Status: Active » Needs review
StatusFileSize
new 3187221-2.patch2 KB
deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

I have manually tested this, and I can see the existing tests are passing. Great work.

It will need tests added.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
StatusFileSize
new 3187221-total_count-4-test_only.patch4.2 KB
new 3187221-total_count-4.patch6.23 KB

I've added two patches, a test only to fail and the combined patch.

There are commented out tests in the patch, as the numbers don't appear correct based on the test data, and in cases where a display doesn't have a pager it returns null instead of a total count.

More work will be required.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Needs work » Needs review
StatusFileSize
new 3187221-total_count-5.patch7.66 KB

Updated patch with fix for null counts, and updated tests.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Needs review » Fixed

Committed. Thanks for the patch @blazey.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.